From: Andi Kleen <andi@firstfloor.org>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Btrfs Development List <linux-btrfs@vger.kernel.org>
Subject: Re: PATCH] btrfs: Check transaction start
Date: Mon, 30 Mar 2009 19:39:44 +0200 [thread overview]
Message-ID: <873acunc4f.fsf@basil.nowhere.org> (raw)
In-Reply-To: <499392D4.5020709@suse.com> (Jeff Mahoney's message of "Wed, 11 Feb 2009 22:09:08 -0500")
Jeff Mahoney <jeffm@suse.com> writes:
> wake_up_process(root->fs_info->cleaner_kthread);
> @@ -2197,10 +2199,12 @@ int btrfs_commit_super(struct btrfs_root
> btrfs_clean_old_snapshots(root);
> mutex_unlock(&root->fs_info->cleaner_mutex);
> trans = btrfs_start_transaction(root, 1);
> + BUG_ON(IS_ERR(trans));
Would it make sense to use a different macro for things that
are expected to be fixed later? BUG_ON_I_SUCK() or TMP_BUG_ON() or
something like that?
I think that would make it clearer that things are only temporary.
At least it should be documented somewhere.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-03-30 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 3:09 PATCH] btrfs: Check transaction start Jeff Mahoney
2009-03-30 17:39 ` Andi Kleen [this message]
2009-03-30 17:44 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873acunc4f.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.