From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp4-g21.free.fr ([212.27.42.4]:45345 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbZCKVV2 (ORCPT ); Wed, 11 Mar 2009 17:21:28 -0400 To: Guennadi Liakhovetski Cc: mike@compulab.co.il, Linux Media Mailing List Subject: Re: [PATCH 2/4] pxa_camera: Redesign DMA handling References: <1236282351-28471-1-git-send-email-robert.jarzmik@free.fr> <1236282351-28471-2-git-send-email-robert.jarzmik@free.fr> <1236282351-28471-3-git-send-email-robert.jarzmik@free.fr> <87sklms9ni.fsf@free.fr> <87r615hwzb.fsf@free.fr> From: Robert Jarzmik Date: Wed, 11 Mar 2009 22:21:16 +0100 In-Reply-To: <87r615hwzb.fsf@free.fr> (Robert Jarzmik's message of "Tue\, 10 Mar 2009 22\:46\:48 +0100") Message-ID: <873adjhi2b.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-media-owner@vger.kernel.org List-ID: Robert Jarzmik writes: > Guennadi Liakhovetski writes: > It is the result of our conversation about "hot DMA linking". I tested both > paths (the optimal one and the one where DMA stops while queuing => > cf. pxa_camera_check_link_miss) for RGB565 format. I'll test further for > YUV422P ... Well, surprise surprise with the YUV422P format. We're not done yet ... There is a little issue with overrun : buf->active_dma is cleared in dma irq handler (for example suppose is cleared of DMA_U which finished first). Then an overrun occurs, and we restart that frame ... We should have reset buf->active_dma to DMA_Y | DMA_U | DMA_V. I think same thing applies to the "hot chain" link miss restart. The non-regression tests are not yet finished ... exciting, isn't it ? :) Cheers. -- Robert