All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferenc Wagner <wferi@niif.hu>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.29-rc2 dies on startup
Date: Wed, 28 Jan 2009 12:33:58 +0100	[thread overview]
Message-ID: <873af33brt.fsf@tac.ki.iif.hu> (raw)
In-Reply-To: Ferenc Wagner's message of "Tue, 27 Jan 2009 18:15:31 +0100"

Ferenc Wagner <wferi@niif.hu> writes:

> Arve Hjønnevåg <arve@android.com> writes:
>
>> On Sun, Jan 25, 2009 at 10:46 PM, Andrew Morton
>> <akpm@linux-foundation.org> wrote:
>>
>>> At a guess I'd say that drivers/staging/android/ram_console.c is calling
>>> the reed-solomon code earlier than it's expecting.  But that might be
>>> totally wrong.
>>
>> Yes, but it also is trying to use a zero sized buffer at virtual
>> address 0 so it will not work much better if you turn off ecc.
>
> This sounds understandable given that the defaults are
>
> CONFIG_ANDROID_RAM_CONSOLE_EARLY_ADDR=0x0
> CONFIG_ANDROID_RAM_CONSOLE_EARLY_SIZE=0x0
>
>> This patch (to the android kernel tree) add some validation:
>
> Compiling it now (on the vanilla tree).

Fine, this patch helps.  Instead of

[    0.000000] Detected 1536.828 MHz processor.
[    0.004000] Console: colour VGA+ 80x25
[    0.004000] console [ttyS0] enabled
[    0.004000] BUG: unable to handle kernel paging request at f000e816
[    0.004000] IP: [<c0190b5c>] kmem_cache_alloc+0x2d/0x95
[...]

now I get

[    0.000000] Detected 1537.027 MHz processor.
[    0.004000] Console: colour VGA+ 80x25
[    0.004000] console [tty0] enabled
[    0.004000] ram_console: buffer (null), invalid size 0, datasize -12
[    0.004000] Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
[...]
-- 
Thanks,
Feri.

  parent reply	other threads:[~2009-01-28 11:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19 12:53 2.6.29-rc2 dies on startup Ferenc Wagner
2009-01-26  6:46 ` Andrew Morton
2009-01-27  0:29   ` Arve Hjønnevåg
2009-01-27 17:13     ` Ferenc Wagner
2009-01-28 11:33     ` Ferenc Wagner [this message]
2009-01-31  3:40     ` Greg KH
2009-01-31  4:21       ` [PATCH] ram_console: Disable ECC when early init is enabled and validate buffer size Arve Hjønnevåg
2009-01-27 16:10   ` 2.6.29-rc2 dies on startup Ferenc Wagner
2009-01-27 16:53     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873af33brt.fsf@tac.ki.iif.hu \
    --to=wferi@niif.hu \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.