All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] make assumed terminal width on cmd help dynamic
Date: Sun, 20 Jul 2008 20:16:30 +0200	[thread overview]
Message-ID: <873am4ju9t.fsf@xs4all.nl> (raw)
In-Reply-To: <89CD688385DC46C0B8A1049A6C2B14F4@fz> (Felix Zielcke's message of "Sun, 20 Jul 2008 15:47:32 +0200")

"Felix Zielcke" <fzielcke@z-51.de> writes:

> Thanks to nyu and daChaac on IRC By default with gfxterm loaded and
> gfxmode set to 640*480 help command produces empty lines see [0] help
> command assumes a fixed width of 80 but gfxterm in 640*480 has only 77
>
> This is a patch to fix it.


Here is the changelog entry from the other mail (just resend the patch
if you have a new changelog entry):

Felix Zielcke <fzielcke@z-51.de>


	* commands/help.c: Include <grub/term.h>.
	(TERM_WIDTH): Redefined to GRUB_TERM_WIDTH.

(two newlines instead of one)

It would be better to replace all users of TERM_WIDTH to use
GRUB_TERM_WIDTH, like you mentioned.  Only ugly thing is that this is
actually a function...

--
Marco




  parent reply	other threads:[~2008-07-20 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-20 13:47 [PATCH] make assumed terminal width on cmd help dynamic Felix Zielcke
2008-07-20 13:53 ` Felix Zielcke
2008-07-20 14:08 ` Felix Zielcke
2008-07-20 18:16 ` Marco Gerards [this message]
2008-07-20 18:52   ` Felix Zielcke
2008-07-20 19:41     ` Marco Gerards
2008-07-26  9:14       ` Marco Gerards
2008-07-27 13:03         ` Robert Millan
2008-07-27 15:50           ` Felix Zielcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873am4ju9t.fsf@xs4all.nl \
    --to=mgerards@xs4all.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.