From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KET5s-0005eS-09 for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 13:59:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KET5q-0005e1-Nb for grub-devel@gnu.org; Thu, 03 Jul 2008 13:59:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KET5p-0005do-5x for grub-devel@gnu.org; Thu, 03 Jul 2008 13:59:42 -0400 Received: from [199.232.76.173] (port=49625 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KET5p-0005dl-0D for grub-devel@gnu.org; Thu, 03 Jul 2008 13:59:41 -0400 Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]:3151) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KET5o-0007YU-Lh for grub-devel@gnu.org; Thu, 03 Jul 2008 13:59:40 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id m63HxdY0053923 for ; Thu, 3 Jul 2008 19:59:39 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080619133147.GA5018@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 03 Jul 2008 20:08:01 +0200 In-Reply-To: <20080619133147.GA5018@thorin> (Robert Millan's message of "Thu, 19 Jun 2008 15:31:47 +0200") Message-ID: <873amq7se6.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] add a counter in grub_dprintf X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 17:59:43 -0000 Robert Millan writes: > How about adding a counter to grub_dprintf to make it easy to instrument > GRUB and find which are the bottlenecks in boot time? > > Sidenote: perhaps it'd be a good idea to conditionalize all grub_dprintf > calls with #ifdef DEBUG to obtain a smaller core.img. It's not hard to > ask a user to rebuild if dprintf is needed, and we can find non-ugly ways > to do this without massive #ifdefs all over the code. How about a configure time switch to *disable* dprintf. I prefer to have it enabled by default. In that case distributions can create two packages. One for normal use and one for debugging. -- Marco