From: Andi Kleen <andi@firstfloor.org>
To: Karsten Wiese <fzu@wemgehoertderstaat.de>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] x86: set_cyc2ns_scale() remove tsc_now and ns_now
Date: Fri, 11 Apr 2008 09:42:48 +0200 [thread overview]
Message-ID: <873apsn8g7.fsf@basil.nowhere.org> (raw)
In-Reply-To: <200804102331.11815.fzu@wemgehoertderstaat.de> (Karsten Wiese's message of "Thu, 10 Apr 2008 23:31:11 +0200")
Karsten Wiese <fzu@wemgehoertderstaat.de> writes:
> Both are unused and the functions rdtscll() and __cycles_2_ns() don't have
> side-effects.
I don't think you should remove those. At some point the offset
needs to be reset when the frequency scale changes for obvious reasons,
and that needs to be fixed, not the code removed. Right now you'll get
scheduling inconsistencies during frequency changes on
!constant_tsc CPUs.
(actually it is still the wrong time -- really needs a grace
period during which the TSC is not used
ftp://firstfloor.org/pub/ak/quilt/patches/sched-clock implemented
some of these ideas against an older kernel)
-Andi
next prev parent reply other threads:[~2008-04-11 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 21:31 [PATCH] x86: set_cyc2ns_scale() remove tsc_now and ns_now Karsten Wiese
2008-04-11 7:42 ` Andi Kleen [this message]
2008-04-11 7:55 ` Ingo Molnar
2008-04-11 8:06 ` Andi Kleen
2008-04-11 8:25 ` Guillaume Chazarain
2008-04-11 8:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873apsn8g7.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=fzu@wemgehoertderstaat.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.