From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JIAEs-0005pM-VE for mharc-grub-devel@gnu.org; Thu, 24 Jan 2008 17:08:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIAEq-0005p9-JW for grub-devel@gnu.org; Thu, 24 Jan 2008 17:08:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIAEp-0005ox-3t for grub-devel@gnu.org; Thu, 24 Jan 2008 17:08:00 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIAEo-0005ou-TO for grub-devel@gnu.org; Thu, 24 Jan 2008 17:07:58 -0500 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JIAEo-0006gI-F0 for grub-devel@gnu.org; Thu, 24 Jan 2008 17:07:58 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0OM7v53097386 for ; Thu, 24 Jan 2008 23:07:57 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com> <4798D42E.7030506@nic.fi> <1201199662.19286.4.camel@dv> <200801242219.55828.okuji@enbug.org> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 24 Jan 2008 23:09:17 +0100 In-Reply-To: <200801242219.55828.okuji@enbug.org> (Yoshinori K. Okuji's message of "Thu, 24 Jan 2008 22:19:55 +0100") Message-ID: <873asm510y.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: /kern/file.c BUG X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2008 22:08:00 -0000 "Yoshinori K. Okuji" writes: > On Thursday 24 January 2008 19:34, Pavel Roskin wrote: >> On Thu, 2008-01-24 at 20:08 +0200, Vesa J=E4=E4skel=E4inen wrote: >> > Previous behavior was working correctly. You have to handle >> > errorcodes >> > at some point and that means when error is handled it is zeroed (or >> > GRUB_ERR_NONE). So code is in callee where that loop was. >> >> I suggest that we never set grub_errno to 0 (except the initialization). >> That would match the standard errno behavior: >> >> http://www.opengroup.org/onlinepubs/009695399/functions/errno.html > > Marco is right. As you pointed out, our error handling is different from = errno=20 > on Unix, but this is intentional, because I stole the model from GRUB Leg= acy=20 > and Parted. It's nice when people say I am right (it should happen more often). But I do not recall participating in this thread. Did I miss something, like I usually do? ;-) -- Marco