From: Jim Meyering <jim@meyering.net>
To: lvm-devel@redhat.com
Subject: Re: LVM2/tools/fsadm Makefile.in
Date: Wed, 03 Oct 2007 12:08:23 +0200 [thread overview]
Message-ID: <873aws4ijs.fsf@rho.meyering.net> (raw)
In-Reply-To: <20071003095830.GH18444@agk.fab.redhat.com> (Alasdair G. Kergon's message of "Wed, 3 Oct 2007 10:58:30 +0100")
Alasdair G Kergon <agk@redhat.com> wrote:
> On Wed, Oct 03, 2007 at 09:46:58AM -0000, meyering at sourceware.org wrote:
>> * tools/fsadm/Makefile.in (LVMLIBS): Define.
>> (fsadm): Link with $(LVMLIBS).
>
>> fsadm: $(OBJECTS)
>> - $(CC) -o $@ $(CFLAGS) $(OBJECTS) -rdynamic
>> + $(CC) -o $@ $(CFLAGS) $(OBJECTS) $(LDFLAGS) $(LVMLIBS) -rdynamic
>
> fsadm is meant to be independent of LVM2 so should not be using LVMLIBS.
> What should be done to deal with this?
Ok.
A few ways to do that:
Move last_path_component from util.c to an independent header and
make it a static inline function, then simply include it from fsadm.c.
Add a Makefile rule that extracts the definition from util.c,
and perhaps adding #include <string.h>,
and making the function static inline.
A couple more. but I have to run.
next prev parent reply other threads:[~2007-10-03 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 9:46 LVM2/tools/fsadm Makefile.in meyering
2007-10-03 9:58 ` Alasdair G Kergon
2007-10-03 10:03 ` Bryn M. Reeves
2007-10-03 10:08 ` Jim Meyering [this message]
2007-10-03 14:59 ` Jim Meyering
2007-10-03 17:09 ` Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2007-10-03 16:08 meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873aws4ijs.fsf@rho.meyering.net \
--to=jim@meyering.net \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.