* Re: [Xen-changelog] Deal with domain info going away (handle new error path introduced by [not found] <E1EFl8U-0005GC-RK@xenbits.xensource.com> @ 2005-09-15 14:58 ` Daniel Stekloff 2005-09-15 16:08 ` Steven Hand 0 siblings, 1 reply; 4+ messages in thread From: Daniel Stekloff @ 2005-09-15 14:58 UTC (permalink / raw) To: xen-devel; +Cc: steven On Thu, 2005-09-15 at 04:14 +0000, Xen patchbot -unstable wrote: > # HG changeset patch > # User shand@ubuntu.eng.hq.xensource.com > # Node ID bd477fcd32aba8a3196873b702ae6ea0d8a7e43b > # Parent 36f8c5900e8646b0465d92d602bd07f3d3b5a966 > Deal with domain info going away (handle new error path introduced by > cset 6828). Believe Dan Smith is working up a more comprehensive patch. > > Signed-off-by: Steven Hand <steven@xensource.com> > > diff -r 36f8c5900e86 -r bd477fcd32ab tools/python/xen/xend/XendDomainInfo.py > --- a/tools/python/xen/xend/XendDomainInfo.py Thu Sep 15 01:46:40 2005 > +++ b/tools/python/xen/xend/XendDomainInfo.py Thu Sep 15 04:12:54 2005 > @@ -353,7 +353,12 @@ > def update(self, info=None): > """Update with info from xc.domain_getinfo(). > """ > - self.info = info or dom_get(self.domid) > + if info: > + self.info = info > + else: > + di = dom_get(self.domid) > + if not di: > + return Um.... shouldn't there be a "self.info = di" somewhere? > self.memory = self.info['mem_kb'] / 1024 > self.ssidref = self.info['ssidref'] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-changelog] Deal with domain info going away (handle new error path introduced by 2005-09-15 14:58 ` [Xen-changelog] Deal with domain info going away (handle new error path introduced by Daniel Stekloff @ 2005-09-15 16:08 ` Steven Hand 2005-09-15 16:20 ` Dan Smith 2005-09-15 17:47 ` Sean Dague 0 siblings, 2 replies; 4+ messages in thread From: Steven Hand @ 2005-09-15 16:08 UTC (permalink / raw) To: Daniel Stekloff; +Cc: xen-devel, Steven.Hand, steven >On Thu, 2005-09-15 at 04:14 +0000, Xen patchbot -unstable wrote: >> # HG changeset patch >> # User shand@ubuntu.eng.hq.xensource.com >> # Node ID bd477fcd32aba8a3196873b702ae6ea0d8a7e43b >> # Parent 36f8c5900e8646b0465d92d602bd07f3d3b5a966 >> Deal with domain info going away (handle new error path introduced by >> cset 6828). Believe Dan Smith is working up a more comprehensive patch. >> >> Signed-off-by: Steven Hand <steven@xensource.com> >> >> diff -r 36f8c5900e86 -r bd477fcd32ab tools/python/xen/xend/XendDomainInfo.py >> --- a/tools/python/xen/xend/XendDomainInfo.py Thu Sep 15 01:46:40 200 5 >> +++ b/tools/python/xen/xend/XendDomainInfo.py Thu Sep 15 04:12:54 200 5 >> @@ -353,7 +353,12 @@ >> def update(self, info=None): >> """Update with info from xc.domain_getinfo(). >> """ >> - self.info = info or dom_get(self.domid) >> + if info: >> + self.info = info >> + else: >> + di = dom_get(self.domid) >> + if not di: >> + return > > > >Um.... shouldn't there be a "self.info = di" somewhere? Oops - yes. cheers, S. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [Xen-changelog] Deal with domain info going away (handle new error path introduced by 2005-09-15 16:08 ` Steven Hand @ 2005-09-15 16:20 ` Dan Smith 2005-09-15 17:47 ` Sean Dague 1 sibling, 0 replies; 4+ messages in thread From: Dan Smith @ 2005-09-15 16:20 UTC (permalink / raw) To: Steven Hand; +Cc: Daniel Stekloff, xen-devel, steven DS> Um.... shouldn't there be a "self.info = di" somewhere? SH> Oops - yes. I'm testing a patch that will clean this all up. I'll post it soon. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-changelog] Deal with domain info going away (handle new error path introduced by 2005-09-15 16:08 ` Steven Hand 2005-09-15 16:20 ` Dan Smith @ 2005-09-15 17:47 ` Sean Dague 1 sibling, 0 replies; 4+ messages in thread From: Sean Dague @ 2005-09-15 17:47 UTC (permalink / raw) To: Steven Hand; +Cc: Daniel Stekloff, xen-devel, steven [-- Attachment #1.1: Type: text/plain, Size: 2232 bytes --] Just as a quick nag, it would be nice if this patch had come across xen-devel *before* being checked in, instead of afterwards. ;) The catch happened pretty quickly on the changelog (thanks Dan), but it would still have been nice to catch it before it broke anyone. -Sean On Thu, Sep 15, 2005 at 05:08:14PM +0100, Steven Hand wrote: > > >On Thu, 2005-09-15 at 04:14 +0000, Xen patchbot -unstable wrote: > >> # HG changeset patch > >> # User shand@ubuntu.eng.hq.xensource.com > >> # Node ID bd477fcd32aba8a3196873b702ae6ea0d8a7e43b > >> # Parent 36f8c5900e8646b0465d92d602bd07f3d3b5a966 > >> Deal with domain info going away (handle new error path introduced by > >> cset 6828). Believe Dan Smith is working up a more comprehensive patch. > >> > >> Signed-off-by: Steven Hand <steven@xensource.com> > >> > >> diff -r 36f8c5900e86 -r bd477fcd32ab tools/python/xen/xend/XendDomainInfo.py > >> --- a/tools/python/xen/xend/XendDomainInfo.py Thu Sep 15 01:46:40 200 > 5 > >> +++ b/tools/python/xen/xend/XendDomainInfo.py Thu Sep 15 04:12:54 200 > 5 > >> @@ -353,7 +353,12 @@ > >> def update(self, info=None): > >> """Update with info from xc.domain_getinfo(). > >> """ > >> - self.info = info or dom_get(self.domid) > >> + if info: > >> + self.info = info > >> + else: > >> + di = dom_get(self.domid) > >> + if not di: > >> + return > > > > > > > >Um.... shouldn't there be a "self.info = di" somewhere? > > Oops - yes. > > cheers, > > S. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > -- __________________________________________________________________ Sean Dague Mid-Hudson Valley sean at dague dot net Linux Users Group http://dague.net http://mhvlug.org There is no silver bullet. Plus, werewolves make better neighbors than zombies, and they tend to keep the vampire population down. __________________________________________________________________ [-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --] [-- Attachment #2: Type: text/plain, Size: 138 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-09-15 17:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1EFl8U-0005GC-RK@xenbits.xensource.com>
2005-09-15 14:58 ` [Xen-changelog] Deal with domain info going away (handle new error path introduced by Daniel Stekloff
2005-09-15 16:08 ` Steven Hand
2005-09-15 16:20 ` Dan Smith
2005-09-15 17:47 ` Sean Dague
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.