From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Dpkkq-0007rC-Mj for mharc-grub-devel@gnu.org; Tue, 05 Jul 2005 06:34:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dpkkk-0007pU-C8 for grub-devel@gnu.org; Tue, 05 Jul 2005 06:34:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dpkkj-0007oj-0a for grub-devel@gnu.org; Tue, 05 Jul 2005 06:34:09 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DpkjL-0006oA-4y for grub-devel@gnu.org; Tue, 05 Jul 2005 06:32:43 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DpkQY-0001IF-C1 for grub-devel@gnu.org; Tue, 05 Jul 2005 06:13:18 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id D287682FE for ; Tue, 5 Jul 2005 12:07:06 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 05181-05 for ; Tue, 5 Jul 2005 11:12:27 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 9C2848273 for ; Tue, 5 Jul 2005 12:07:03 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 60FBEC046 for ; Tue, 5 Jul 2005 12:07:03 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42C84FF8.8020102@yahoo.fr> <42C94B8A.2070709@yahoo.fr> <200507050110.43155.okuji@enbug.org> From: Marco Gerards Date: Tue, 05 Jul 2005 12:07:03 +0200 In-Reply-To: <200507050110.43155.okuji@enbug.org> (Yoshinori K. Okuji's message of "Tue, 5 Jul 2005 01:10:42 +0200") Message-ID: <873bqtva60.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [Bulk] [PATCH] Small unicode problem fix in normal/menu.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2005 10:34:12 -0000 "Yoshinori K. Okuji" writes: > On Monday 04 July 2005 16:45, Vincent Pelletier wrote: >> ncurses-like (not macros !) : >> >> void grub_getyx (unsigned int &y, unsigned int &x) >> void grub_getmaxyx (unsigned int &y, unsigned int &x) /* to get the term >> size */ > > My feeling is that it is not convenient to use pointers. For example, when I > just want to know if the position is 0 or not in the x axis, I can do this in > the current API: > > if (grub_getxy () >> 8) > > But if I need to use a pointer, this becomes: > > unsigned x; > grub_getyx (0, &x); > if (x) > > Well, this might be just a preference. Yeah, personally I prefer pointers to do this. how about adding: inline unsigned grub_getx (void) { return grub_getxy () >> 8; } Or a macro or so which does the same. Thanks, Marco