From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DVZ77-0001RV-P0 for mharc-grub-devel@gnu.org; Tue, 10 May 2005 14:05:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DVZ6z-0001Os-Q5 for grub-devel@gnu.org; Tue, 10 May 2005 14:05:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DVZ6w-0001MJ-2Q for grub-devel@gnu.org; Tue, 10 May 2005 14:05:38 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DVZ6v-0001I1-NP for grub-devel@gnu.org; Tue, 10 May 2005 14:05:37 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DVZA5-00031r-F7 for grub-devel@gnu.org; Tue, 10 May 2005 14:08:53 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 4DB579BF3 for ; Tue, 10 May 2005 20:01:40 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 17107-08 for ; Tue, 10 May 2005 20:01:38 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 2C5B89ABA for ; Tue, 10 May 2005 20:01:38 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id E68A1C047 for ; Tue, 10 May 2005 20:01:37 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050510013936.GA20230@miracle> From: Marco Gerards Date: Tue, 10 May 2005 20:01:39 +0200 In-Reply-To: <20050510013936.GA20230@miracle> (Hollis Blanchard's message of "Mon, 9 May 2005 20:39:36 -0500") Message-ID: <873bsvq7ss.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [ppc] [patch] more cleanups X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2005 18:05:44 -0000 Hollis Blanchard writes: > I've found a few more things that needed cleaning, so here is the > updated patch. I have tested it. It looks fine to me. I have a few questions: > (grub_ieee1275_next_property): Likewise. Change type of first argument > to grub_ieee1275_phandle_t. Please use double spaces. > --- include/grub/powerpc/ieee1275/kernel.h 4 Jan 2005 14:01:45 -0000 1.1 > +++ include/grub/powerpc/ieee1275/kernel.h 10 May 2005 01:27:36 -0000 > @@ -21,6 +21,6 @@ > #define GRUB_KERNEL_MACHINE_HEADER 1 > > /* Where grub-mkimage places the core modules in memory. */ > -#define GRUB_IEEE1275_MODULE_BASE 0x0300000 > +#define GRUB_IEEE1275_MODULE_BASE 0x00300000 Huh? Can you explain this? I would even prefer: #define GRUB_IEEE1275_MODULE_BASE 0x300000 > Index: loader/powerpc/ieee1275/linux.c [...] > - initrd_addr = 0xc0000000; > + initrd_addr = 0; Does loading linux with an initrd still work? Thanks, Marco