From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
nicola.vetrini@gmail.com, xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH 3/3] xen/efi: efibind: Drop alternative define for old GCC versions
Date: Thu, 14 Aug 2025 09:48:41 +0200 [thread overview]
Message-ID: <87420043-c081-4d2e-af09-cc7f8ae642ca@suse.com> (raw)
In-Reply-To: <a4ff322a-8cf3-4e8f-b243-6153e823eafd@citrix.com>
On 14.08.2025 00:39, Andrew Cooper wrote:
> On 13/08/2025 8:12 pm, nicola.vetrini@gmail.com wrote:
>> From: Nicola Vetrini <nicola.vetrini@gmail.com>
>>
>> Since the toolchain baseline for GCC is 5.1, there is no need for
>> this case.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@gmail.com>
>> ---
>> Mentioned in https://gitlab.com/xen-project/xen/-/issues/201
>
> I personally am in favour of this change, but in the past there has been
> objection to changing this header it is vendered from elsewhere.
The two lines Nicola is taking out altogether were our additions already
anyway. Playing with them ought to be fine. Context may better be left
intact. I'd like to note though that in gnuefi the detection logic has
changed, too. Maintainers may want to sync that.
As to me, earlier on, objecting to fiddling with imported files here:
Now that maintainership has changed, the new maintainers will need to
make up their take on this.
Jan
prev parent reply other threads:[~2025-08-14 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 19:12 [XEN PATCH 0/3] Drop alternative definitions for unsupported GCCs nicola.vetrini
2025-08-13 19:12 ` [XEN PATCH 1/3] xen/compiler: drop alternative unreachable() definition for older GCC nicola.vetrini
2025-08-13 22:32 ` Andrew Cooper
2025-08-13 19:12 ` [XEN PATCH 2/3] xen/macros: Drop alternative definition of BUILD_BUG_ON(_ZERO)? for old GCC nicola.vetrini
2025-08-13 22:33 ` Andrew Cooper
2025-08-14 8:07 ` Jan Beulich
2025-08-14 9:16 ` Nicola Vetrini
2025-08-13 19:12 ` [XEN PATCH 3/3] xen/efi: efibind: Drop alternative define for old GCC versions nicola.vetrini
2025-08-13 22:39 ` Andrew Cooper
2025-08-14 7:48 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87420043-c081-4d2e-af09-cc7f8ae642ca@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=marmarek@invisiblethingslab.com \
--cc=nicola.vetrini@gmail.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.