From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:33938 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbeCTNOc (ORCPT ); Tue, 20 Mar 2018 09:14:32 -0400 From: Laurent Pinchart To: Arnd Bergmann Cc: Frank.Rowand@sony.com, David Airlie , niklas.soderlund+renesas@ragnatech.se, dri-devel , Linux-Renesas , Linux Kernel Mailing List , Frank Rowand Subject: Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build Date: Tue, 20 Mar 2018 15:15:37 +0200 Message-ID: <8748007.hiNNEuVPPY@avalon> In-Reply-To: References: <20180315153730.3798004-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Arnd, On Friday, 16 March 2018 10:25:25 EET Arnd Bergmann wrote: > On Fri, Mar 16, 2018 at 2:39 AM, wrote: > > On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann wrote: > >> The *.dtb and *.dtb.S files get removed by 'make' during the build > >> process, > >> and later seem to be missed during the 'modpost' stage: > >> > >> rm drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb.S > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb.S > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb.S > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb.S > >> WARNING: could not open > >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S: No such file or > >> directory > >> > >> As a workaround, this adds all those files to the 'extra-y' target list, > >> but that's really ugly. Any ideas for a better fix? > > > > Does this work for you (untested, but the way it is done in > > drivers/of/unittest-data/Makefile): > > > > .PRECIOUS: \ > > > > $(obj)/%.dtb.S \ > > $(obj)/%.dtb > > Yes, that works and looks much better than my version. Thank you for your patch, and sorry for breaking the build. Do you plan to submit a new version based on Frank's approach ? -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build Date: Tue, 20 Mar 2018 15:15:37 +0200 Message-ID: <8748007.hiNNEuVPPY@avalon> References: <20180315153730.3798004-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AB8E6E735 for ; Tue, 20 Mar 2018 13:14:33 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: niklas.soderlund+renesas@ragnatech.se, David Airlie , Linux Kernel Mailing List , dri-devel , Linux-Renesas , Frank Rowand , Frank.Rowand@sony.com List-Id: dri-devel@lists.freedesktop.org SGkgQXJuZCwKCk9uIEZyaWRheSwgMTYgTWFyY2ggMjAxOCAxMDoyNToyNSBFRVQgQXJuZCBCZXJn bWFubiB3cm90ZToKPiBPbiBGcmksIE1hciAxNiwgMjAxOCBhdCAyOjM5IEFNLCAgPEZyYW5rLlJv d2FuZEBzb255LmNvbT4gd3JvdGU6Cj4gPiBPbiBUaHVyc2RheSwgTWFyY2ggMTUsIDIwMTggODoz NyBBTSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiA+PiBUaGUgKi5kdGIgYW5kICouZHRiLlMgZmls ZXMgZ2V0IHJlbW92ZWQgYnkgJ21ha2UnIGR1cmluZyB0aGUgYnVpbGQKPiA+PiBwcm9jZXNzLAo+ ID4+IGFuZCBsYXRlciBzZWVtIHRvIGJlIG1pc3NlZCBkdXJpbmcgdGhlICdtb2Rwb3N0JyBzdGFn ZToKPiA+PiAKPiA+PiBybSBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNf cjhhNzc5NS5kdGIKPiA+PiBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNf cjhhNzc5MS5kdGIKPiA+PiBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNf cjhhNzc5MS5kdGIuUwo+ID4+IGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2ZfbHZk c19yOGE3Nzk1LmR0Yi5TCj4gPj4gZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9vZl9s dmRzX3I4YTc3OTAuZHRiLlMKPiA+PiBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29m X2x2ZHNfcjhhNzc5My5kdGIKPiA+PiBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29m X2x2ZHNfcjhhNzc5Ni5kdGIKPiA+PiBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29m X2x2ZHNfcjhhNzc5MC5kdGIKPiA+PiBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29m X2x2ZHNfcjhhNzc5Ni5kdGIuUwo+ID4+IGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVf b2ZfbHZkc19yOGE3NzkzLmR0Yi5TCj4gPj4gV0FSTklORzogY291bGQgbm90IG9wZW4KPiA+PiBk cml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNfcjhhNzc5MC5kdGIuUzogTm8g c3VjaCBmaWxlIG9yCj4gPj4gZGlyZWN0b3J5Cj4gPj4gCj4gPj4gQXMgYSB3b3JrYXJvdW5kLCB0 aGlzIGFkZHMgYWxsIHRob3NlIGZpbGVzIHRvIHRoZSAnZXh0cmEteScgdGFyZ2V0IGxpc3QsCj4g Pj4gYnV0IHRoYXQncyByZWFsbHkgdWdseS4gQW55IGlkZWFzIGZvciBhIGJldHRlciBmaXg/Cj4g PiAKPiA+IERvZXMgdGhpcyB3b3JrIGZvciB5b3UgKHVudGVzdGVkLCBidXQgdGhlIHdheSBpdCBp cyBkb25lIGluCj4gPiBkcml2ZXJzL29mL3VuaXR0ZXN0LWRhdGEvTWFrZWZpbGUpOgo+ID4gCj4g PiAuUFJFQ0lPVVM6IFwKPiA+IAo+ID4gICAgICAgICAkKG9iaikvJS5kdGIuUyBcCj4gPiAgICAg ICAgICQob2JqKS8lLmR0Ygo+IAo+IFllcywgdGhhdCB3b3JrcyBhbmQgbG9va3MgbXVjaCBiZXR0 ZXIgdGhhbiBteSB2ZXJzaW9uLgoKVGhhbmsgeW91IGZvciB5b3VyIHBhdGNoLCBhbmQgc29ycnkg Zm9yIGJyZWFraW5nIHRoZSBidWlsZC4gRG8geW91IHBsYW4gdG8gCnN1Ym1pdCBhIG5ldyB2ZXJz aW9uIGJhc2VkIG9uIEZyYW5rJ3MgYXBwcm9hY2ggPwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBp bmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK