From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE221C4332F for ; Tue, 7 Nov 2023 21:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RqtKSDE66apLF6N4T2YcqqP985DOJFfMa87yMFvSmfA=; b=cwWvMQQb8J0nMO 79p2KhMjwuOrGz1mfPPUiV4JLD9QovJG1xqTnJwDQcyTjCqtlsO9PvDRDF1Pr3viM4AvOlX2Qw7wx d9/tciGSpbVj/vTTPELQ58f3S5K233IXdIhZmOxX6tz15rG8SMHBvNfRZ+oGQfyfNfNtVZbsejjIQ 7d2hlaSk63inW/jKayvbf0eXbvvvpXy33260ZlNTQgrNExfaXfU+/ysuw+9SzEDNPuXeoDeq4EiNk q/rtdxQURMyeemIbOJlAS0v5fru64+otLubvUyJR1I8vNKVTUWczB8R8j/PA2BCzC29bD47xGXiz5 e7TaDk2h+t0uFoiOCnrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Tr0-002SYA-1Y; Tue, 07 Nov 2023 21:43:22 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Tqx-002SV6-1c for linux-rockchip@lists.infradead.org; Tue, 07 Nov 2023 21:43:21 +0000 Received: from [100.84.166.245] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2BDF06607401; Tue, 7 Nov 2023 21:43:10 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1699393391; bh=OBGXpRnlFzwp5OJvsG7Sy/2FmTCeMQkmDM476G9u2lQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TJkRjPGYStWKLmgF4ytNxy65LpERkg2dKy1ux0ILCyKTeeCi4qte6wNFyGIOJWuqU SxZO3WMhxY7ER10ROewX/cbWVm4+qdEqHAJWZz2nOcaUpYmlJ7OsBv+F5YiHNZQoMc w9foClFwkz4cSXk2w1dgZ50Qx7mOB1qjfe6epDv3sv8Qv5RlH27oPDRzfaMdQv5O8V qrzM9J4wO7WucGvtYfSRhRT7NnxeDooGvTdQ25ZG8mon+hxDQxIN9pfw6UQBXDBB35 Wlv8gzV237j780ulrj2yhHtEPoLifclMP+shWl9l9RZUkQYxRrsDC3y3a5jI1Y0YdM vXWTl3Vv6Fajg== Message-ID: <874b6ea3309ff302dcdd9ff92f9098130b979c27.camel@collabora.com> Subject: Re: [PATCH v4 00/11] media: rkvdec: Add H.264 High 10 and 4:2:2 profile support From: Nicolas Dufresne To: Jonas Karlman , Ezequiel Garcia , Mauro Carvalho Chehab , Hans Verkuil Cc: Alex Bee , Benjamin Gaignard , Sebastian Fricke , Christopher Obbard , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Tue, 07 Nov 2023 16:43:01 -0500 In-Reply-To: <20231105165521.3592037-1-jonas@kwiboo.se> References: <20231105165521.3592037-1-jonas@kwiboo.se> User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_134319_810378_48225F5E X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgSm9uYXMsCgp0aGFua3MgZm9yIHRoaXMgd29yay4KCkxlIGRpbWFuY2hlIDA1IG5vdmVtYnJl IDIwMjMgw6AgMTY6NTQgKzAwMDAsIEpvbmFzIEthcmxtYW4gYSDDqWNyaXTCoDoKPiBUaGlzIGlz IGEgcmV2aXZhbCBvZiBhIDMgeWVhciBvbGQgc2VyaWVzIFsxXSBub3cgdGhhdCBOVjE1L05WMjAv TlYzMCBzdXBwb3J0Cj4gZm9yIGRpc3BsYXkgZHJpdmVyIGhhdmUgbGFuZGVkIGluIG1haW5saW5l IHRyZWUuCj4gCj4gVGhpcyBzZXJpZXMgYWRkcyBILjI2NCBIaWdoIDEwIGFuZCA0OjI6MiBwcm9m aWxlIHN1cHBvcnQgdG8gdGhlIFJvY2tjaGlwCj4gVmlkZW8gRGVjb2RlciBkcml2ZXIuCj4gCj4g UGF0Y2ggMSBhZGRzIGhlbHBlcnMgZm9yIGNhbGN1bGF0aW5nIHBsYW5lIGJ5dGVzcGVybGluZSBh bmQgc2l6ZWltYWdlLgo+IFBhdGNoIDIgYWRkcyB0d28gbmV3IHBpeGVsZm9ybWF0cyBmb3Igc2Vt aS1wbGFuZXIgMTAtYml0IDQ6MjowLzQ6MjoyIFlVVi4KPiAKPiBQYXRjaCAzIGNoYW5nZSB0byB1 c2UgYnl0ZXNwZXJsaW5lIGFuZCBidWZmZXIgaGVpZ2h0IHRvIGNvbmZpZ3VyZSBzdHJpZGVzLgo+ IFBhdGNoIDQgY2hhbmdlIHRvIHVzZSB2YWx1ZXMgZnJvbSBTUFMvUFBTIGNvbnRyb2wgdG8gY29u ZmlndXJlIHRoZSBIVy4KPiBQYXRjaCA1IHJlbW92ZSBhbiB1bm5lY2Vzc2FyeSBjYWxsIHRvIHZh bGlkYXRlIHNwcyBhdCBzdHJlYW1pbmcgc3RhcnQuCj4gCj4gUGF0Y2ggNi0xMCByZWZhY3RvciBj b2RlIHRvIHN1cHBvcnQgZmlsdGVyaW5nIG9mIENBUFVUUkUgZm9ybWF0cyBiYXNlZAo+IG9uIHRo ZSBpbWFnZSBmb3JtYXQgcmV0dXJuZWQgZnJvbSBhIGdldF9pbWFnZV9mbXQgb3BzLgo+IAo+IFBh dGNoIDExIGFkZHMgZmluYWwgYml0cyB0byBzdXBwb3J0IEguMjY0IEhpZ2ggMTAgYW5kIDQ6Mjoy IHByb2ZpbGVzLgo+IAo+IFRlc3RlZCBvbiBhIFJPQ0sgUGkgNCAoUkszMzk5KSBhbmQgUm9jazY0 IChSSzMzMjgpOgo+IAo+ICAgdjRsMi1jb21wbGlhbmNlIDEuMjQuMSwgNjQgYml0cywgNjQtYml0 IHRpbWVfdAo+ICAgLi4uCj4gICBUb3RhbCBmb3Igcmt2ZGVjIGRldmljZSAvZGV2L3ZpZGVvMTog NDYsIFN1Y2NlZWRlZDogNDYsIEZhaWxlZDogMCwgV2FybmluZ3M6IDAKPiAKPiAgIFJ1bm5pbmcg dGVzdCBzdWl0ZSBKVlQtRlItRVhUIHdpdGggZGVjb2RlciBGRm1wZWctSC4yNjQtVjRMMi1yZXF1 ZXN0Cj4gICAuLi4KPiAgIFJhbiA2NS82OSB0ZXN0cyBzdWNjZXNzZnVsbHkKCkkgYWRkZWQgR1N0 cmVhbWVyIHN1cHBvcnQgZm9yIHRoZXNlIGZvcm1hdHMgYW5kIGNvdWxkIGNvbmZpcm0gdGhpcwpy ZXN1bHRzIHdpdGggR1N0cmVhbWVyIHRvby4KCmh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9y Zy9nc3RyZWFtZXIvZ3N0cmVhbWVyLy0vbWVyZ2VfcmVxdWVzdHMvNTYxMgoKCkZvciB0aGUgc2V0 OgpUZXN0ZWQtYnk6IE5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3Jh LmNvbT4KCj4gCj4gICBSdW5uaW5nIHRlc3Qgc3VpdGUgSlZULUFWQ19WMSB3aXRoIGRlY29kZXIg RkZtcGVnLUguMjY0LVY0TDItcmVxdWVzdAo+ICAgLi4uCj4gICBSYW4gMTI3LzEzNSB0ZXN0cyBz dWNjZXNzZnVsbHkKCkknbSBnZXR0aW5nIDEyOSB3aXRoIEdTdHJlYW1lciwgd2hpY2ggbWF0Y2hl cyBhbHNvIHdpdGggRkZNcGVnIHNvZnR3YXJlCmRlY29kZXIuCgo+IAo+IEJlZm9yZSB0aGlzIHNl cmllczoKPiAKPiAgIFJ1bm5pbmcgdGVzdCBzdWl0ZSBKVlQtRlItRVhUIHdpdGggZGVjb2RlciBG Rm1wZWctSC4yNjQtVjRMMi1yZXF1ZXN0Cj4gICAuLi4KPiAgIFJhbiA0NC82OSB0ZXN0cyBzdWNj ZXNzZnVsbHkKCkkgaGFkIDQzIHdpdGggR1N0cmVhbWVyLCBidXQgdGhlbiBJIG5vdGljZSB5b3Ug Zml4ZWQgc29tZXRoaW5nIGluCmZsdXN0ZXIuIFRoZSBnb29kIG5ld3MgdGhpcyBpcyBub3cgdXBz dHJlYW0sIHRoYW5rcyBmb3Igc3BvdHRpbmcuCgpodHRwczovL2dpdGh1Yi5jb20vZmx1ZW5kby9m bHVzdGVyL3B1bGwvMTQ4Cgo+IAo+IENoYW5nZXMgaW4gdjQ6Cj4gLSBGaXggZmFpbGVkIHY0bDIt Y29tcGxpYW5jZSB0ZXN0cyByZWxhdGVkIHRvIENBUFRVUkUgcXVldWUKPiAtIFJld29yayBDQVBU VVJFIGZvcm1hdCBmaWx0ZXIgYW52IHZhbGlkYXRlIHRvIHVzZSBhbiBpbWFnZSBmb3JtYXQKPiAt IFJ1biBmbHVzdGVyIHRlc3Qgc3VpdGUgSlZULUZSLUVYVCBbNF0gYW5kIEpWVC1BVkNfVjEgWzVd Cj4gTGluayB0byB2MzogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtbWVkaWEvMjAyMzEw MjkxODM0MjcuMTc4MTU1NC0xLWpvbmFzQGt3aWJvby5zZS8KPiAKPiBDaGFuZ2VzIGluIHYzOgo+ IC0gRHJvcCBtZXJnZWQgcGF0Y2hlcwo+IC0gVXNlIGJwcCBhbmQgYnBwX2RpdiBpbnN0ZWFkIG9m IHByaW9yIG1pc3VzZSBvZiBibG9ja193L2Jsb2NrX2gKPiAtIE5ldyBwYXRjaCB0byB1c2UgdmFs dWVzIGZyb20gU1BTL1BQUyBjb250cm9sIHRvIGNvbmZpZ3VyZSB0aGUgSFcKPiAtIE5ldyBwYXRj aCB0byByZW1vdmUgYW4gdW5uZWNlc3NhcnkgY2FsbCB0byB2YWxpZGF0ZSBzcHMgYXQgc3RyZWFt aW5nIHN0YXJ0Cj4gLSBSZXdvcmtlZCBwaXhlbCBmb3JtYXQgdmFsaWRhdGlvbgo+IExpbmsgdG8g djI6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW1lZGlhLzIwMjAwNzA2MjE1NDMwLjIy ODU5LTEtam9uYXNAa3dpYm9vLnNlLwo+IAo+IENoYW5nZXMgaW4gdjI6Cj4gLSBDb2xsZWN0IHIt YiB0YWdzCj4gLSBTUFMgcGljIHdpZHRoIGFuZCBoZWlnaHQgaW4gbWJzIHZhbGlkYXRpb24gbW92 ZWQgdG8gcmt2ZGVjX3RyeV9jdHJsCj4gLSBOZXcgcGF0Y2ggdG8gbm90IG92ZXJyaWRlIG91dHB1 dCBidWZmZXIgc2l6ZWltYWdlCj4gLSBSZXdvcmtlZCBwaXhlbCBmb3JtYXQgdmFsaWRhdGlvbgo+ IC0gT25seSBhbGlnbiBkZWNvZGVkIGJ1ZmZlciBpbnN0ZWFkIG9mIGNoYW5naW5nIGZybXNpemUg c3RlcF93aWR0aAo+IExpbmsgdG8gdjE6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW1l ZGlhLzIwMjAwNzAxMjE1NjE2LjMwODc0LTEtam9uYXNAa3dpYm9vLnNlLwo+IAo+IEZvbGxvd2lu ZyBjb21taXRzIGFkZHMgc3VwcG9ydCBmb3IgTlYxNS9OVjIwL05WMzAgdG8gVk9QIGRyaXZlcjoK PiA3MjhjMTViNGI1ZjMgKCJkcm0vZm91cmNjOiBBZGQgTlYyMCBhbmQgTlYzMCBZVVYgZm9ybWF0 cyIpCj4gZDRiMzg0MjI4NTYyICgiZHJtL3JvY2tjaGlwOiB2b3A6IEFkZCBOVjE1LCBOVjIwIGFu ZCBOVjMwIHN1cHBvcnQiKQo+IAo+IFRvIGZ1bGx5IHJ1bnRpbWUgdGVzdCB0aGlzIHNlcmllcyB5 b3UgbWF5IG5lZWQgYWJvdmUgZHJtIGNvbW1pdHMgYW5kIGZmbXBlZwo+IHBhdGNoZXMgZnJvbSBb Ml0sIHRoaXMgc2VyaWVzIGFuZCBkcm0gcGF0Y2hlcyBpcyBhbHNvIGF2YWlsYWJsZSBhdCBbM10u Cj4gCj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LW1lZGlhLzIwMjAwNzA2MjE1 NDMwLjIyODU5LTEtam9uYXNAa3dpYm9vLnNlLwo+IFsyXSBodHRwczovL2dpdGh1Yi5jb20vS3dp Ym9vL0ZGbXBlZy9jb21taXRzL3Y0bDItcmVxdWVzdC1uNi4xLWRldi8KPiBbM10gaHR0cHM6Ly9n aXRodWIuY29tL0t3aWJvby9saW51eC1yb2NrY2hpcC9jb21taXRzL2xpbnV4dHYtcmt2ZGVjLWhp Z2gtMTAtdjQvCj4gWzRdIGh0dHBzOi8vZ2lzdC5naXRodWIuY29tL0t3aWJvby9mNGFjMTU1NzZi MmM3Mjg4N2FlMmJjNWQ1OGI1Yzg2NQo+IFs1XSBodHRwczovL2dpc3QuZ2l0aHViLmNvbS9Ld2li b28vNDU5YTFjOGYxZGNiNTZlNDVkYzdhN2EyOWNjMjhhZGYKPiAKPiBSZWdhcmRzLAo+IEpvbmFz Cj4gCj4gQWxleCBCZWUgKDEpOgo+ICAgbWVkaWE6IHJrdmRlYzogaDI2NDogRG9uJ3QgaGFyZGNv ZGUgU1BTL1BQUyBwYXJhbWV0ZXJzCj4gCj4gSm9uYXMgS2FybG1hbiAoMTApOgo+ICAgbWVkaWE6 IHY0bDItY29tbW9uOiBBZGQgaGVscGVycyB0byBjYWxjdWxhdGUgYnl0ZXNwZXJsaW5lIGFuZAo+ ICAgICBzaXplaW1hZ2UKPiAgIG1lZGlhOiB2NGwyOiBBZGQgTlYxNSBhbmQgTlYyMCBwaXhlbCBm b3JtYXRzCj4gICBtZWRpYTogcmt2ZGVjOiBoMjY0OiBVc2UgYnl0ZXNwZXJsaW5lIGFuZCBidWZm ZXIgaGVpZ2h0IGFzIHZpcnN0cmlkZQo+ICAgbWVkaWE6IHJrdmRlYzogaDI2NDogUmVtb3ZlIFNQ UyB2YWxpZGF0aW9uIGF0IHN0cmVhbWluZyBzdGFydAo+ICAgbWVkaWE6IHJrdmRlYzogRXh0cmFj dCBya3ZkZWNfZmlsbF9kZWNvZGVkX3BpeGZtdCBpbnRvIGhlbHBlcgo+ICAgbWVkaWE6IHJrdmRl YzogTW92ZSBya3ZkZWNfcmVzZXRfZGVjb2RlZF9mbXQgaGVscGVyCj4gICBtZWRpYTogcmt2ZGVj OiBFeHRyYWN0IGRlY29kZWQgZm9ybWF0IGVudW1lcmF0aW9uIGludG8gaGVscGVyCj4gICBtZWRp YTogcmt2ZGVjOiBBZGQgaW1hZ2UgZm9ybWF0IGNvbmNlcHQKPiAgIG1lZGlhOiBya3ZkZWM6IEFk ZCBnZXRfaW1hZ2VfZm10IG9wcwo+ICAgbWVkaWE6IHJrdmRlYzogaDI2NDogU3VwcG9ydCBIaWdo IDEwIGFuZCA0OjI6MiBwcm9maWxlcwo+IAo+ICAuLi4vbWVkaWEvdjRsL3BpeGZtdC15dXYtcGxh bmFyLnJzdCAgICAgICAgICAgfCAxMjggKysrKysrKysrKysKPiAgZHJpdmVycy9tZWRpYS92NGwy LWNvcmUvdjRsMi1jb21tb24uYyAgICAgICAgIHwgIDgwICsrKy0tLS0KPiAgZHJpdmVycy9tZWRp YS92NGwyLWNvcmUvdjRsMi1pb2N0bC5jICAgICAgICAgIHwgICAyICsKPiAgZHJpdmVycy9zdGFn aW5nL21lZGlhL3JrdmRlYy9ya3ZkZWMtaDI2NC5jICAgIHwgIDgzICsrKy0tLS0KPiAgZHJpdmVy cy9zdGFnaW5nL21lZGlhL3JrdmRlYy9ya3ZkZWMuYyAgICAgICAgIHwgMjE3ICsrKysrKysrKysr KystLS0tLQo+ICBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvcmt2ZGVjL3JrdmRlYy5oICAgICAgICAg fCAgMTggKy0KPiAgaW5jbHVkZS91YXBpL2xpbnV4L3ZpZGVvZGV2Mi5oICAgICAgICAgICAgICAg IHwgICAyICsKPiAgNyBmaWxlcyBjaGFuZ2VkLCAzOTYgaW5zZXJ0aW9ucygrKSwgMTM0IGRlbGV0 aW9ucygtKQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1902F840 for ; Tue, 7 Nov 2023 21:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="TJkRjPGY" Received: from [100.84.166.245] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2BDF06607401; Tue, 7 Nov 2023 21:43:10 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1699393391; bh=OBGXpRnlFzwp5OJvsG7Sy/2FmTCeMQkmDM476G9u2lQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TJkRjPGYStWKLmgF4ytNxy65LpERkg2dKy1ux0ILCyKTeeCi4qte6wNFyGIOJWuqU SxZO3WMhxY7ER10ROewX/cbWVm4+qdEqHAJWZz2nOcaUpYmlJ7OsBv+F5YiHNZQoMc w9foClFwkz4cSXk2w1dgZ50Qx7mOB1qjfe6epDv3sv8Qv5RlH27oPDRzfaMdQv5O8V qrzM9J4wO7WucGvtYfSRhRT7NnxeDooGvTdQ25ZG8mon+hxDQxIN9pfw6UQBXDBB35 Wlv8gzV237j780ulrj2yhHtEPoLifclMP+shWl9l9RZUkQYxRrsDC3y3a5jI1Y0YdM vXWTl3Vv6Fajg== Message-ID: <874b6ea3309ff302dcdd9ff92f9098130b979c27.camel@collabora.com> Subject: Re: [PATCH v4 00/11] media: rkvdec: Add H.264 High 10 and 4:2:2 profile support From: Nicolas Dufresne To: Jonas Karlman , Ezequiel Garcia , Mauro Carvalho Chehab , Hans Verkuil Cc: Alex Bee , Benjamin Gaignard , Sebastian Fricke , Christopher Obbard , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Tue, 07 Nov 2023 16:43:01 -0500 In-Reply-To: <20231105165521.3592037-1-jonas@kwiboo.se> References: <20231105165521.3592037-1-jonas@kwiboo.se> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Jonas, thanks for this work. Le dimanche 05 novembre 2023 =C3=A0 16:54 +0000, Jonas Karlman a =C3=A9crit= =C2=A0: > This is a revival of a 3 year old series [1] now that NV15/NV20/NV30 supp= ort > for display driver have landed in mainline tree. >=20 > This series adds H.264 High 10 and 4:2:2 profile support to the Rockchip > Video Decoder driver. >=20 > Patch 1 adds helpers for calculating plane bytesperline and sizeimage. > Patch 2 adds two new pixelformats for semi-planer 10-bit 4:2:0/4:2:2 YUV. >=20 > Patch 3 change to use bytesperline and buffer height to configure strides= . > Patch 4 change to use values from SPS/PPS control to configure the HW. > Patch 5 remove an unnecessary call to validate sps at streaming start. >=20 > Patch 6-10 refactor code to support filtering of CAPUTRE formats based > on the image format returned from a get_image_fmt ops. >=20 > Patch 11 adds final bits to support H.264 High 10 and 4:2:2 profiles. >=20 > Tested on a ROCK Pi 4 (RK3399) and Rock64 (RK3328): >=20 > v4l2-compliance 1.24.1, 64 bits, 64-bit time_t > ... > Total for rkvdec device /dev/video1: 46, Succeeded: 46, Failed: 0, Warn= ings: 0 >=20 > Running test suite JVT-FR-EXT with decoder FFmpeg-H.264-V4L2-request > ... > Ran 65/69 tests successfully I added GStreamer support for these formats and could confirm this results with GStreamer too. https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5612 For the set: Tested-by: Nicolas Dufresne >=20 > Running test suite JVT-AVC_V1 with decoder FFmpeg-H.264-V4L2-request > ... > Ran 127/135 tests successfully I'm getting 129 with GStreamer, which matches also with FFMpeg software decoder. >=20 > Before this series: >=20 > Running test suite JVT-FR-EXT with decoder FFmpeg-H.264-V4L2-request > ... > Ran 44/69 tests successfully I had 43 with GStreamer, but then I notice you fixed something in fluster. The good news this is now upstream, thanks for spotting. https://github.com/fluendo/fluster/pull/148 >=20 > Changes in v4: > - Fix failed v4l2-compliance tests related to CAPTURE queue > - Rework CAPTURE format filter anv validate to use an image format > - Run fluster test suite JVT-FR-EXT [4] and JVT-AVC_V1 [5] > Link to v3: https://lore.kernel.org/linux-media/20231029183427.1781554-1-= jonas@kwiboo.se/ >=20 > Changes in v3: > - Drop merged patches > - Use bpp and bpp_div instead of prior misuse of block_w/block_h > - New patch to use values from SPS/PPS control to configure the HW > - New patch to remove an unnecessary call to validate sps at streaming st= art > - Reworked pixel format validation > Link to v2: https://lore.kernel.org/linux-media/20200706215430.22859-1-jo= nas@kwiboo.se/ >=20 > Changes in v2: > - Collect r-b tags > - SPS pic width and height in mbs validation moved to rkvdec_try_ctrl > - New patch to not override output buffer sizeimage > - Reworked pixel format validation > - Only align decoded buffer instead of changing frmsize step_width > Link to v1: https://lore.kernel.org/linux-media/20200701215616.30874-1-jo= nas@kwiboo.se/ >=20 > Following commits adds support for NV15/NV20/NV30 to VOP driver: > 728c15b4b5f3 ("drm/fourcc: Add NV20 and NV30 YUV formats") > d4b384228562 ("drm/rockchip: vop: Add NV15, NV20 and NV30 support") >=20 > To fully runtime test this series you may need above drm commits and ffmp= eg > patches from [2], this series and drm patches is also available at [3]. >=20 > [1] https://lore.kernel.org/linux-media/20200706215430.22859-1-jonas@kwib= oo.se/ > [2] https://github.com/Kwiboo/FFmpeg/commits/v4l2-request-n6.1-dev/ > [3] https://github.com/Kwiboo/linux-rockchip/commits/linuxtv-rkvdec-high-= 10-v4/ > [4] https://gist.github.com/Kwiboo/f4ac15576b2c72887ae2bc5d58b5c865 > [5] https://gist.github.com/Kwiboo/459a1c8f1dcb56e45dc7a7a29cc28adf >=20 > Regards, > Jonas >=20 > Alex Bee (1): > media: rkvdec: h264: Don't hardcode SPS/PPS parameters >=20 > Jonas Karlman (10): > media: v4l2-common: Add helpers to calculate bytesperline and > sizeimage > media: v4l2: Add NV15 and NV20 pixel formats > media: rkvdec: h264: Use bytesperline and buffer height as virstride > media: rkvdec: h264: Remove SPS validation at streaming start > media: rkvdec: Extract rkvdec_fill_decoded_pixfmt into helper > media: rkvdec: Move rkvdec_reset_decoded_fmt helper > media: rkvdec: Extract decoded format enumeration into helper > media: rkvdec: Add image format concept > media: rkvdec: Add get_image_fmt ops > media: rkvdec: h264: Support High 10 and 4:2:2 profiles >=20 > .../media/v4l/pixfmt-yuv-planar.rst | 128 +++++++++++ > drivers/media/v4l2-core/v4l2-common.c | 80 +++---- > drivers/media/v4l2-core/v4l2-ioctl.c | 2 + > drivers/staging/media/rkvdec/rkvdec-h264.c | 83 +++---- > drivers/staging/media/rkvdec/rkvdec.c | 217 +++++++++++++----- > drivers/staging/media/rkvdec/rkvdec.h | 18 +- > include/uapi/linux/videodev2.h | 2 + > 7 files changed, 396 insertions(+), 134 deletions(-) >=20