All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vasiliy Kovalev <kovalev@altlinux.org>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nikita Maksimov <nickstogramm@yandex.ru>
Subject: Re: [PATCH] ALSA: hda/via: Apply runtime PM workaround for ASUS X55A
Date: Sun, 18 Oct 2026 10:33:45 +0200	[thread overview]
Message-ID: <874iej1k7q.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261017101257.215166-1-kovalev@altlinux.org>

On Sat, 17 Oct 2026 12:12:57 +0200,
Vasiliy Kovalev wrote:
> 
> ASUS X55A requires the same workaround like other machines with
> VT1802, otherwise it loses the codec power on a few nodes and the
> sound stays silent.
> 
> Fixes: a0645daf1610 ("ALSA: HDA: Early Forbid of runtime PM")
> Link: https://bugzilla.altlinux.org/45606
> Cc: <stable@vger.kernel.org>
> Tested-by: Nikita Maksimov <nickstogramm@yandex.ru>
> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>

The addition of a quirk is OK, but is Fixes tag really pointing to the
culprit?  The commit is for forbidding the runtime PM, and I see no
clear reason how this commit breaks.


thanks,

Takashi

> ---
>  sound/hda/codecs/via.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/via.c b/sound/hda/codecs/via.c
> index 807312cffd35..0641fc14b346 100644
> --- a/sound/hda/codecs/via.c
> +++ b/sound/hda/codecs/via.c
> @@ -933,6 +933,7 @@ static const struct hda_fixup via_fixups[] = {
>  static const struct hda_quirk vt2002p_fixups[] = {
>  	SND_PCI_QUIRK(0x1043, 0x13f7, "Asus B23E", VIA_FIXUP_POWER_SAVE),
>  	SND_PCI_QUIRK(0x1043, 0x1487, "Asus G75", VIA_FIXUP_ASUS_G75),
> +	SND_PCI_QUIRK(0x1043, 0x1c33, "Asus X55A", VIA_FIXUP_POWER_SAVE),
>  	SND_PCI_QUIRK(0x1043, 0x8532, "Asus X202E", VIA_FIXUP_INTMIC_BOOST),
>  	SND_PCI_QUIRK_VENDOR(0x1558, "Clevo", VIA_FIXUP_POWER_SAVE),
>  	{}
> -- 
> 2.50.1
> 

  reply	other threads:[~2026-10-18  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 10:12 [PATCH] ALSA: hda/via: Apply runtime PM workaround for ASUS X55A Vasiliy Kovalev
2026-10-18  8:33 ` Takashi Iwai [this message]
2026-10-18  8:50   ` Vasiliy Kovalev
2026-10-18  9:34     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874iej1k7q.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kovalev@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=nickstogramm@yandex.ru \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.