All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael Roth" <michael.roth@amd.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Kashyap Chamarthy" <kchamart@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Jason Wang" <jasowangio@gmail.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Kostiantyn Kostiuk" <kkostiuk@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	qemu-block@nongnu.org, qemu-trivial@nongnu.org,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Eric Blake" <eblake@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>
Subject: Re: [PATCH 7/9] qapi: convert intro sections for docs/interop/firmware.json
Date: Tue, 22 Sep 2026 17:04:50 +0200	[thread overview]
Message-ID: <874ifh499p.fsf@pond.sub.org> (raw)
In-Reply-To: <20260921205147.1857168-8-jsnow@redhat.com> (John Snow's message of "Mon, 21 Sep 2026 16:51:45 -0400")

John Snow <jsnow@redhat.com> writes:

> All conversions in this patch do not create a new documentation
> insertion point, except for one at the very end.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  docs/interop/firmware.json | 76 ++++++++++++++++----------------------
>  1 file changed, 31 insertions(+), 45 deletions(-)
>
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index 421bee0e5ed..1efd32c6315 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json

[...]

> @@ -250,12 +244,11 @@
>  
>  ##
>  # @FirmwareFlashFile:
> -#
> -# Defines common properties that are necessary for loading a firmware
> -# file into a pflash chip.  The corresponding QEMU command line option
> -# is "-drive file=@filename,format=@format".  Note however that the
> -# option-argument shown here is incomplete; it is completed under
> -# @FirmwareMappingFlash.
> +#     Defines common properties that are necessary for loading a
> +#     firmware file into a pflash chip.  The corresponding QEMU
> +#     command line option is "-drive file=@filename,format=@format".
> +#     Note however that the option-argument shown here is incomplete;
> +#     it is completed under @FirmwareMappingFlash.
>  #
>  # @filename: Specifies the filename on the host filesystem where the
>  #     firmware file can be found.

This smells like it could use a split, but it doesn't really matter;
let's move on.

[...]

> @@ -467,9 +454,8 @@
>  
>  ##
>  # @Firmware:
> -#
> -# Describes a firmware (or a firmware use case) to management
> -# software.
> +#     Describes a firmware (or a firmware use case) to management
> +#     software.
>  #
>  # It is possible for multiple @Firmware elements to match the search
>  # criteria of management software.  Applications thus need rules to

This is the split you mentioned in the commit message.  Correct?



  reply	other threads:[~2026-09-22 15:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 20:51 [PATCH 0/9] qapi: convert intros for qga, firmware, etc John Snow
2026-09-21 20:51 ` [PATCH 1/9] qapi: convert remaining simple sections John Snow
2026-09-22 14:34   ` Markus Armbruster
2026-09-21 20:51 ` [PATCH 3/9] qapi: convert trivial intros for qga/qapi-schema.json John Snow
2026-09-21 20:51 ` [PATCH 4/9] qapi: convert simple " John Snow
2026-09-23  6:47   ` Markus Armbruster
2026-09-21 20:51 ` [PATCH 6/9] qapi: split " John Snow
2026-09-22 15:21   ` Markus Armbruster
2026-09-21 20:51 ` [PATCH 7/9] qapi: convert intro sections for docs/interop/firmware.json John Snow
2026-09-22 15:04   ` Markus Armbruster [this message]
2026-09-22 17:41     ` John Snow
2026-09-21 20:51 ` [PATCH 8/9] qapi: convert intro sections for docs/interop/vhost-user.json John Snow
     [not found] ` <20260921205147.1857168-6-jsnow@redhat.com>
2026-09-22 14:53   ` [PATCH 5/9] qapi: split intros at natural cutoff points for qga/qapi-schema.json Markus Armbruster
2026-09-22 17:33     ` John Snow
     [not found] ` <20260921205147.1857168-3-jsnow@redhat.com>
2026-09-22 17:05   ` [PATCH 2/9] qapi: convert intro sections for unit tests Markus Armbruster
2026-09-22 17:29     ` John Snow
2026-09-23  6:35       ` Markus Armbruster
     [not found] ` <20260921205147.1857168-10-jsnow@redhat.com>
2026-09-22 17:10   ` [PATCH 9/9] tests/qapi: generate output in source order Markus Armbruster
2026-09-22 17:46     ` John Snow
2026-09-23  6:32       ` Markus Armbruster
2026-09-22 17:47 ` [PATCH 0/9] qapi: convert intros for qga, firmware, etc John Snow
2026-09-22 19:48   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ifh499p.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=jsnow@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=kkostiuk@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=michael.roth@amd.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.