From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] configure: correctly honour --disable-containers
Date: Tue, 01 Sep 2026 19:55:19 +0100 [thread overview]
Message-ID: <874ig8u7hk.fsf@draig.linaro.org> (raw)
In-Reply-To: <20260901163858.1570626-1-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Tue, 1 Sep 2026 17:38:58 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> The configure script originally only probed for 'runc' command
> in order to handle cross-compilation containers. The Makefile
> under tests/docker would then probe again when used.
>
> In order to eliminate the additional probeing, we changed
> configure in commit c4ce04cfb7460d46c0262d437a7f35bb5c5fc449
> to always probe for 'runc', so the result could be passed
> along to tests/docker make rules.
>
> That commit overlooked that the 'probe_target_compiler' func
> was relying on '$runc' == 'no' as a proxy for the state of
> the --disable-containers arg.
>
> When we started unconditionally probing, that short cut no
> longer works and we must explicitly check "$use_containers"
> too.
>
> Fixes: c4ce04cfb7460d46c0262d437a7f35bb5c5fc449
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2026-09-01 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 16:38 [PATCH] configure: correctly honour --disable-containers Daniel P. Berrangé
2026-09-01 18:55 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ig8u7hk.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.