All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: 빛나는황소 <safenine@gmail.com>
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
	Aaron Fan <aaronfan404@gmail.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for LG Gram 17ZD90R-EX79K
Date: Mon, 03 Aug 2026 09:05:54 +0200	[thread overview]
Message-ID: <874ihbbs4t.wl-tiwai@suse.de> (raw)
In-Reply-To: <878q6nbsb1.wl-tiwai@suse.de>

On Mon, 03 Aug 2026 09:02:10 +0200,
Takashi Iwai wrote:
> 
> On Thu, 30 Jul 2026 06:20:09 +0200,
> 빛나는황소 wrote:
> > 
> > From: Jabong Koo <safenine@gmail.com>
> > 
> > The internal speakers on the LG Gram 17ZD90R-EX79K remain silent,
> > while headphone output works normally.
> > 
> > The machine uses a Realtek ALC298 codec with PCI subsystem ID
> > 1854:048b. Existing LG Gram subsystem IDs 1854:0488, 1854:0489 and
> > 1854:048a use ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS, but 1854:048b is
> > missing from the quirk table.
> > 
> > Add the matching quirk for subsystem ID 1854:048b.
> > 
> > Tested successfully on Ubuntu HWE kernels 6.17.0-41-generic and
> > 7.0.0-28-generic.
> > 
> > Signed-off-by: Jabong Koo <safenine@gmail.com>
> > ---
> >  sound/hda/codecs/realtek/alc269.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/sound/hda/codecs/realtek/alc269.c
> > b/sound/hda/codecs/realtek/alc269.c
> > --- a/sound/hda/codecs/realtek/alc269.c
> > +++ b/sound/hda/codecs/realtek/alc269.c
> > @@ -7752,6 +7752,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> >  	SND_PCI_QUIRK(0x1854, 0x0488, "LG gram 16 (16Z90R)",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> >  	SND_PCI_QUIRK(0x1854, 0x0489, "LG gram 16 (16Z90R-A)",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> >  	SND_PCI_QUIRK(0x1854, 0x048a, "LG gram 17 (17ZD90R)",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> > +	SND_PCI_QUIRK(0x1854, 0x048b, "LG gram 17 (17ZD90R-EX79K)",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> >  	SND_PCI_QUIRK(0x1854, 0x05bf, "LG gram 17ZD90S",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> >  	SND_PCI_QUIRK(0x1854, 0x05c0, "LG gram 16Z90S",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> >  	SND_PCI_QUIRK(0x1854, 0x05c1, "LG gram 14Z90S",
> > ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS),
> 
> The patch looks malformed (with wrong spaces), likely due to your
> mailer, so it can't be applied cleanly via git-am.
> Please fix your mailer setup, and resubmit the fix.

Never mind, I see that there was another fix submission by Aaron for
the very same device with the same quirk, and it was applied now.


thanks,

Takashi

      reply	other threads:[~2026-08-03  7:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30  4:20 [PATCH] ALSA: hda/realtek: Add quirk for LG Gram 17ZD90R-EX79K 빛나는황소
2026-08-03  7:02 ` Takashi Iwai
2026-08-03  7:05   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ihbbs4t.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=aaronfan404@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=safenine@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.