From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D37C35202C for ; Wed, 15 Jul 2026 07:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784099418; cv=none; b=ZZMgPvxmveEPSZcViL2VX9ZJT5x7jqr/89d1EbTaMWhZ/Ump8MPD1MArxKRGbgVFpuX3YBwKNCPsfH6Z+ZT53Dikr9KJ10243kf3VyMaCENXkHvGguk4JB8/Gmz0SLHsuVO+8X30tIscN+vStGKBkkQI3+52S0uYluGth01/5ec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784099418; c=relaxed/simple; bh=3z04RqdJNlUwzE1VfnYkNCjWO8JVCLO1bObTzhvjCLY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=DgC5e5wIn6bxZaQDlSxC51/aOVhk6TncQCgaymobOCAKb980+m7Ps54bbJ/PPJfp9dXPbfocjklsz6wNvNa/5/vxsAo+05sK+bMcN8AbowuWtlhebdW963cPjM+qu5422UjvOAeK9U6xMQDsim4zdiOw/5GRrC996QU6Uvpo4gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OWufE8XM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OWufE8XM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E12961F000E9; Wed, 15 Jul 2026 07:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784099416; bh=YGi5iHUc55gqia+8qdTQN7A3sbX4YbMMaxug8tjzWKw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=OWufE8XMsYDWde6RvzdoSz24qK1b0z9xZX2zqYJUdYMM35xz3ld0y+XMCC4kKMQ7G RP7gukvzltfzo55F/Zj71cqFDbHRrHWyoASseZVRLjTPjkH4ew43X30sKkKBiE8eE/ BlFcUsNy2uwCaNdu2nyXnAMKh/0BhZ046haqJAsv+2DL75jWKpZiUlYACyZ+ypGUV6 ATz+cn9aiz5cpFItkon9hDnIZF+TZIIMYzCYNK2uRWHU2I2d+tW4fjXCbphA/YWmb6 pISDFnDkuhBAUf1vAsEshKk6RCnLcNJm8FI16y/Sk2H24ICcKiLsexTvL8pVsTakwf CHjpxxtAagVog== From: Thomas Gleixner To: Rustam Adilov , Birger Koblitz , Bert Vermeulen , John Crispin , linux-kernel@vger.kernel.org Cc: Rustam Adilov , Carlo Szelinsky , Markus Stockhausen Subject: Re: [PATCH] irqchip/irq-realtek-rtl: change to __raw reads and writes In-Reply-To: <20260711082328.43535-1-adilov@disroot.org> References: <20260711082328.43535-1-adilov@disroot.org> Date: Wed, 15 Jul 2026 09:10:12 +0200 Message-ID: <874ii0pw2z.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sat, Jul 11 2026 at 13:23, Rustam Adilov wrote: > To make the interrupt driver operable with SWAP_IO_SPACE > config enabled, replace all instances of readl/writel with > their __raw variants. Otherwise readl/writel will do a byte > swap which this driver does not intend to do. Sorry, but this word salad does not qualify as a change log. See https://docs.kernel.org/process/maintainer-tip.html#changelog First you want to explain what the context: When CONFIG_SWAP_IO_SPACE is enabled readl() and writel() imply a byte swap. Then you want to explain why this is not correct for this driver/hardware. Just saying 'does not intend to do' contains zero information: This is incorrect for the RTL driver, because Then you tell how you cure it: Fix this by converting the MMIO accesses to __raw_readl() and __raw_writel(), which do not byte swap the data. Thanks, tglx