Re: [PATCH 1/4] drm/xe: Reformat xe_rtp_types.h

[Gustavo Sousa <gustavo.sousa@intel.com>]

Matt Roper <matthew.d.roper@intel.com> writes:

> Adjust whitespace / newlines in xe_rtp_types.h to make it easier to read
> and more consistent with other files.  No functional change.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_rtp_types.h | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_rtp_types.h b/drivers/gpu/drm/xe/xe_rtp_types.h
> index 58018ae4f8cc..1d7c63d0ae94 100644
> --- a/drivers/gpu/drm/xe/xe_rtp_types.h
> +++ b/drivers/gpu/drm/xe/xe_rtp_types.h
> @@ -22,20 +22,24 @@ struct xe_gt;
>   */
>  struct xe_rtp_action {
>  	/** @reg: Register */
> -	struct xe_reg		reg;
> +	struct xe_reg reg;
> +
>  	/**
>  	 * @clr_bits: bits to clear when updating register. It's always a
>  	 * superset of bits being modified
>  	 */
> -	u32			clr_bits;
> +	u32 clr_bits;
> +
>  	/** @set_bits: bits to set when updating register */
> -	u32			set_bits;
> +	u32 set_bits;
> +
>  #define XE_RTP_NOCHECK		.read_mask = 0
>  	/** @read_mask: mask for bits to consider when reading value back */
> -	u32			read_mask;
> +	u32 read_mask;
> +
>  #define XE_RTP_ACTION_FLAG_ENGINE_BASE		BIT(0)
>  	/** @flags: flags to apply on rule evaluation or action */
> -	u8			flags;
> +	u8 flags;
>  };
>  
>  enum {
> @@ -69,6 +73,7 @@ struct xe_rtp_rule {
>  			u8 platform;
>  			u8 subplatform;
>  		};
> +
>  		/*
>  		 * MATCH_GRAPHICS_VERSION / XE_RTP_MATCH_GRAPHICS_VERSION_RANGE /
>  		 * MATCH_MEDIA_VERSION  / XE_RTP_MATCH_MEDIA_VERSION_RANGE
> @@ -78,15 +83,18 @@ struct xe_rtp_rule {
>  #define XE_RTP_END_VERSION_UNDEFINED	U32_MAX
>  			u32 ver_end;
>  		};
> +
>  		/* MATCH_STEP */
>  		struct {
>  			u8 step_start;
>  			u8 step_end;
>  		};
> +
>  		/* MATCH_ENGINE_CLASS / MATCH_NOT_ENGINE_CLASS */
>  		struct {
>  			u8 engine_class;
>  		};
> +
>  		/* MATCH_FUNC */
>  		bool (*match_func)(const struct xe_device *xe,
>  				   const struct xe_gt *gt,
>
> -- 
> 2.54.0