Re: [PATCH v3 09/11] audio: do not build audio-related sources with --disable-audio

[Markus Armbruster <armbru@redhat.com>]

"Sergei Heifetz" <heifetz@yandex-team.com> writes:

> On Thu Mar 19, 2026 at 1:36 PM +05, Markus Armbruster wrote:
>> [...]
>>> index 2df87b97101..28fda7c8ac3 100644
>>> --- a/qapi/audio.json
>>> +++ b/qapi/audio.json
>>> @@ -540,4 +540,5 @@
>>>  # Since: 8.0
>>>  ##
>>>  { 'command': 'query-audiodevs',
>>> -  'returns': ['Audiodev'] }
>>> +  'returns': ['Audiodev'],
>>> +  'if': 'CONFIG_AUDIO' }
>>
>> Could we disable all the audio stuff here?
>>
>> I tried, patch appended.  What do you think?
>
> For some reason, I thought it was undesirable to alter the header files.
> That's what I had in mind while working on the series.
>
> In particular, when you previously suggested emptying out audio.json,
> I used that idea to find other parts of the source code we can compile
> out, but I thought that was it, and that there is no real reason to
> actually remove the QAPI definitions.
>
> I don't have any strong arguments against it. If we are okay with
> changing the headers, what you suggest makes perfect sense.

We'd add a bunch of #if defined(CONFIG_AUDIO) to generated
qapi-*-audio.h.

If these were handwritten, would we do the same?

I figure we would, because that way we get compile errors instead of
link errors.  Likely one big #ifdef to guard everything but #include.

>>> [...]
>>>
>>> +#include "qemu/osdep.h"
>>> +#include "system/replay.h"
>>> +
>>> +void replay_audio_in_start(size_t *nsamples)
>>> +{
>>> +}
>>> +void replay_audio_in_sample_lr(uint64_t *left, uint64_t *right)
>>> +{
>>> +}
>>> +void replay_audio_in_finish(void)
>>> +{
>>> +}
>>> +void replay_audio_out(size_t *played)
>>> +{
>>> +}
>>
>> Should this go into stubs/ instead?  Genuine question!  I can't tell
>> when we use stubs/foo*.c and when we use foo/*stub.c.
>
> I don't think we should move this to stubs/ unless we also move 
> replay/stubs-system.c there. I put the new file in replay/ because 
> that's where these stubs originally came from.
>
> Also, here is a quote from stubs/meson.build: 'If possible, add new
> files to other directories, by using "if_false"'.

Alright, I learned something :)

>> [...]
>
> P.S. Thank you for the review and for your suggestions. I'm really
> grateful for them. I'm still interested in working on this, and I'm very
> sorry it took so long to respond. 

No worries!