From: Takashi Iwai <tiwai@suse.de>
To: "René Rebe" <rene@exactco.de>
Cc: linux-sound@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: usb-audio fix uac2 clock source
Date: Tue, 25 Nov 2025 15:55:54 +0100 [thread overview]
Message-ID: <874iqip3et.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251125.154149.1121389544970412061.rene@exactco.de>
On Tue, 25 Nov 2025 15:41:49 +0100,
René Rebe wrote:
>
> Since 8b3a087f7f65 ("ALSA: usb-audio: Unify virtual type units type to
> UAC3 values") usb-audio is using UAC3_CLOCK_SOURCE instead of
> bDescriptorSubtype, later refactored with e0ccdef9265 ("ALSA: usb-audio:
> Clean up check_input_term()") into parse_term_uac2_clock_source().
>
> This breaks the clock source selection for at least my
> 1397:0003 BEHRINGER International GmbH FCA610 Pro.
>
> Fix by using UAC2_CLOCK_SOURCE in parse_term_uac2_clock_source().
>
> Fixes: 8b3a087f7f65 ("ALSA: usb-audio: Unify virtual type units type to UAC3 values")
> Signed-off-by: René Rebe <rene@exactco.de>
> ---
> Tested and shipped since 2022-07-24 in T2/Linux.
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-11-25 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 14:41 [PATCH] ALSA: usb-audio fix uac2 clock source René Rebe
2025-11-25 14:55 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874iqip3et.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-sound@vger.kernel.org \
--cc=rene@exactco.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.