From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ED70CCF9F8 for ; Fri, 7 Nov 2025 08:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O0KgrmVD/IyZcpNcToD+Um0TVj7VViGMEX1nH0Ao+uM=; b=Cx22frKSpAL3M7 fN5qX/xm4DjspBqSOFNCCrSEYMrABjOMLK6NSQMbWHv6eMTSZjYBcduoEnvo/ihZh4/U0JygBkgoL us/M6a8rkKchUXjXUNLOeovR9IQZy26wO8qGpCj7u0KXY4Pn1sogqobKkvdd39+OXVQs4G0lenZ6T avSNrXCc31bW02GPLPU8zkiymCmeYcctdUhRBYTlgCTigdDscl49x3129i3/YIIifAxpFEoqXh71p V76XQtCARGeTWcRzhz7crlIzgiPSnOOe0/609z2wmuWlJi3YX5L0a1rtRRUJqWroe/1G0IhHp8RTS XVJln/xKh7rzrgJEFTlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHHl2-0000000GrqI-2INo; Fri, 07 Nov 2025 08:23:44 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHHky-0000000Grph-1K81 for linux-mtd@lists.infradead.org; Fri, 07 Nov 2025 08:23:42 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 7FCA81A1916; Fri, 7 Nov 2025 08:23:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 45E2D6070B; Fri, 7 Nov 2025 08:23:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C6301185123C; Fri, 7 Nov 2025 09:23:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1762503816; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=tgaD8rjkXyLYWq0MjyglgznDWdH1xBP/wgwuMKwG6Pc=; b=hC6Ybp7CevBpMo9V2AKZi62zde0rkJ18ZNGd39fzBSskzr3UJS+9nopOLQUgupWO7r9coQ O4KUFo6V7ida1bgUWk+nhnABVueggPqH8ptt/2rCHXA36hqXvavQZ5M8jJuuscflWPgtXj s+3C3OBq/wwzGQLkNP3BCEQUB8a5OWlRZmZhMY+RQYvKF7+czxG9jJLJAE9Vle/E9nweBF FS5qRI12FUBkFa5w83lQvIhOUbiECdLKRsiOSGyBOcRELO4aMySv3YCFCV/QC+ctJ/9STk fri5sXqfNv0vvpTHtHvK2WLXrpm4c5GH820WygJl28LX7w/i0T9sXFkEkIH1Ow== From: Miquel Raynal To: Cheng Ming Lin Cc: richard@nod.at, chengzhihao1@huawei.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw, Cheng Ming Lin Subject: Re: [PATCH 1/1] mtd: ubi: skip programming unused bits in ubi headers In-Reply-To: (Cheng Ming Lin's message of "Fri, 7 Nov 2025 14:31:12 +0800") References: <20251106054940.2728641-1-linchengming884@gmail.com> <20251106054940.2728641-2-linchengming884@gmail.com> <87o6pf8r24.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 07 Nov 2025 09:23:29 +0100 Message-ID: <874ir68d4u.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251107_002340_679266_430B4B9B X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgo+PiA+ICsgICAgIGlmICh1YmktPnZpZF9oZHJfc2hpZnQpCj4+ID4gKyAgICAgICAg ICAgICBtZW1zZXQoKGNoYXIgKilwLCAweEZGLCB1YmktPnZpZF9oZHJfYWxzaXplIC0gVUJJX1ZJ RF9IRFJfU0laRSk7Cj4+ID4gKyAgICAgZWxzZQo+PiA+ICsgICAgICAgICAgICAgbWVtc2V0KChj aGFyICopcCArIFVCSV9WSURfSERSX1NJWkUsIDB4RkYsIHViaS0+dmlkX2hkcl9hbHNpemUgLSBV QklfVklEX0hEUl9TSVpFKTsKPj4KPj4gSGVyZSBJIGFtIHJlYWNoaW5nIHRoZSBsaW1pdHMgb2Yg bXkgVUJJIGtub3dsZWRnZSwgc28gSSB3b3VsZCBwcmVmZXIKPj4gUmljaGFyZCB0byAoaW4pdmFs aWRhdGUgd2hhdCBJIGFtIHNheWluZywgYnV0IEFGQUlVLCB0aGUgVklEIGhlYWRlciBjYW4KPj4g YmUgbGl0ZXJhbGx5IGFueXdoZXJlIGluIHRoZSBwYWdlLCBub3QganVzdCBhdCB0aGUgc3RhcnQg b3IgZW5kIG9mIGEKPj4gc3VicGFnZSwgc28gaW4gdGhlIHZpZF9oZHJfc2hpZnQgSSB3b3VsZCBl eHBlY3Qgc29tZSBleHRyYSBtYXRocyB0bwo+PiBoYXBwZW4sIG5vPwo+Cj4gSSB1bmRlcnN0YW5k IHlvdXIgcG9pbnQgbm93LiBJZiB0aGUgVklEIGhlYWRlciBpcyBub3QgZ3VhcmFudGVlZCB0byBi ZQo+IGF0IHRoZSBzdGFydCBvciBlbmQgb2YgYSBzdWJwYWdlLCB0aGVuIHllcywgbXkgY3VycmVu dCBsb2dpYyBuZWVkcyB0byBiZQo+IHJld29ya2VkIHRvIGNvdmVyIHRoYXQgY2FzZS4KCkkgZG9u J3Qga25vdyBpZiB0aGlzIGlzIGVhc3kgdG8gZG8sIGJ1dCBtYXliZSB5b3UgY2FuIG1lbXNldCB0 aGUgd2hvbGUKYnVmZmVyIGJlZm9yZSBmaWxsaW5nIGl0LiBUaGF0IHdvdWxkIGF2b2lkIHRoZSBu ZWVkIHRvIGtub3cgd2hlcmUgdGhlClZJRCBoZWFkZXIgd2lsbCBiZS4KClRoYW5rcywKTWlxdcOo bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99051DE2A7 for ; Fri, 7 Nov 2025 08:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762503825; cv=none; b=bKA+8TeC6Y1YNEjKe3UpHHLtfBIxRIS2NVk0W3BGlzQbPMOeXTBa17AcIfpfglOyEvzfoWQXGD99546u5m58HQ/Ck+JtgI+SSEC1Dq0/S8+igAQM1I2Fqu2qLvvdZbwGV0hfeQ1kS+N5owJZ1Cy2CD/tzagUSZEycuih3aATPZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762503825; c=relaxed/simple; bh=tKf9hicyZnGFrTfWX2o+XRStC8ukCbUa/kgb7DlZK5E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=s7XLF/kvtMfwbKwrDsVZw7ObL2I6LKGAXM77DCeU98Cxam/fh4i11ohbbGaaAYd04UE3e+p1hmnMxga7mU7wYUV9maNBpBG59Nf1AyufQzg7wGvO9yJGd5IXf3U75oulZ4/dskhs+oxIjAPr1M8iORUCKPk/I9IGp2fp0E4Mru4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=hC6Ybp7C; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="hC6Ybp7C" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 7FCA81A1916; Fri, 7 Nov 2025 08:23:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 45E2D6070B; Fri, 7 Nov 2025 08:23:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C6301185123C; Fri, 7 Nov 2025 09:23:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1762503816; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=tgaD8rjkXyLYWq0MjyglgznDWdH1xBP/wgwuMKwG6Pc=; b=hC6Ybp7CevBpMo9V2AKZi62zde0rkJ18ZNGd39fzBSskzr3UJS+9nopOLQUgupWO7r9coQ O4KUFo6V7ida1bgUWk+nhnABVueggPqH8ptt/2rCHXA36hqXvavQZ5M8jJuuscflWPgtXj s+3C3OBq/wwzGQLkNP3BCEQUB8a5OWlRZmZhMY+RQYvKF7+czxG9jJLJAE9Vle/E9nweBF FS5qRI12FUBkFa5w83lQvIhOUbiECdLKRsiOSGyBOcRELO4aMySv3YCFCV/QC+ctJ/9STk fri5sXqfNv0vvpTHtHvK2WLXrpm4c5GH820WygJl28LX7w/i0T9sXFkEkIH1Ow== From: Miquel Raynal To: Cheng Ming Lin Cc: richard@nod.at, chengzhihao1@huawei.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw, Cheng Ming Lin Subject: Re: [PATCH 1/1] mtd: ubi: skip programming unused bits in ubi headers In-Reply-To: (Cheng Ming Lin's message of "Fri, 7 Nov 2025 14:31:12 +0800") References: <20251106054940.2728641-1-linchengming884@gmail.com> <20251106054940.2728641-2-linchengming884@gmail.com> <87o6pf8r24.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 07 Nov 2025 09:23:29 +0100 Message-ID: <874ir68d4u.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello, >> > + if (ubi->vid_hdr_shift) >> > + memset((char *)p, 0xFF, ubi->vid_hdr_alsize - UBI_VID_HD= R_SIZE); >> > + else >> > + memset((char *)p + UBI_VID_HDR_SIZE, 0xFF, ubi->vid_hdr_= alsize - UBI_VID_HDR_SIZE); >> >> Here I am reaching the limits of my UBI knowledge, so I would prefer >> Richard to (in)validate what I am saying, but AFAIU, the VID header can >> be literally anywhere in the page, not just at the start or end of a >> subpage, so in the vid_hdr_shift I would expect some extra maths to >> happen, no? > > I understand your point now. If the VID header is not guaranteed to be > at the start or end of a subpage, then yes, my current logic needs to be > reworked to cover that case. I don't know if this is easy to do, but maybe you can memset the whole buffer before filling it. That would avoid the need to know where the VID header will be. Thanks, Miqu=C3=A8l