Re: [PATCH RFC Dovetail 6.16 5/5] kernel/irq/chip: Do not call low level irq chip hooks directly

[Philippe Gerum <rpm@xenomai.org>]

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> On Sun, 2025-09-28 at 10:12 +0200, Philippe Gerum wrote:
>> Florian Bezdeka <florian.bezdeka@siemens.com> writes:
>> 
>> > irq_mask() and irq_unmask() are tracking a software IRQ state that
>> > might run out of sync when bypassing them.
>> > 
>> > No functional change.
>> > 
>> 
>> Actually, there is. Percpu IRQs are not serialized by the desc->lock, so
>> calling mask_irq/unmask_irq in these handlers is unsafe since we may end
>> up flipping bits from the irqd state concurrently on multiple CPUs for
>> the same descriptor. This is the reason why masking/unmasking was
>> open-coded there.  This patch typically breaks my kvm/arm64 fixture at
>> boot, not observed on kvm/x86 so far though.
>> 
>
> I clearly missed the serialization part. Wondering why this did not
> trigger on any board / kvm test...
>
> Anyway, it's clear that this patch should be dropped.
>
> Do you want me to resend the series with 5/5 dropped?
>

No need for this. I'll pick the rest of the series directly. Thanks.

-- 
Philippe.