All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Guillaume La Roque <glaroque@baylibre.com>,
	vigneshr@ti.com, Nishanth Menon <nm@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Tero Kristo <kristo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Guillaume La Roque <glaroque@baylibre.com>
Subject: Re: [PATCH 1/2] kernel: irq: msi: Export symbols for TI SCI INTA MSI module compilation
Date: Fri, 18 Jul 2025 22:57:10 +0200	[thread overview]
Message-ID: <874iv9w72x.ffs@tglx> (raw)
In-Reply-To: <20250707-timsi-v1-1-80ae43b2c550@baylibre.com>

On Mon, Jul 07 2025 at 17:35, Guillaume La Roque wrote:

The made up subsystem prefix is not really useful. See:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

> Export MSI domain management functions to allow the TI SCI INTA MSI
> driver to be compiled as a module. The following symbols are now
> available for module use:

While symbols is technically correct, it's way simpler to understand
that these are functions.

> - msi_domain_insert_msi_desc

And with that you want to use function notation, i.e. foo() instead of foo.

Thanks,

        tglx


  reply	other threads:[~2025-07-18 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 15:35 [PATCH 0/2] Enable TI SCI INTA MSI as loadable module Guillaume La Roque
2025-07-07 15:35 ` [PATCH 1/2] kernel: irq: msi: Export symbols for TI SCI INTA MSI module compilation Guillaume La Roque
2025-07-18 20:57   ` Thomas Gleixner [this message]
2025-07-22  8:03     ` Guillaume La Roque
2025-07-07 15:35 ` [PATCH 2/2] soc: ti: ti_sci_inta_msi: Enable module compilation support Guillaume La Roque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874iv9w72x.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=glaroque@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.