From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15383C19F32 for ; Thu, 27 Feb 2025 14:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pFVTbK4mRvt9b3UQvUIFz5KPCEuWUVdVEmb5RxmPMeI=; b=QOEMflieUa7F9+ yJu/Sqr4foZSBPM2rrF4FMx3pqBD+qPNpZ+X8PBlo7uszmCn6na1OmvEGGPhe9gf+nRkRzZcSA/iw aMK+m1WKfjzGTsgLK0xssM4ZLQqjeEg9vY9rGls1VavZ5+WNyNVDZko9YuwdAGrxyYtR7yp2DC5U4 RWy/5i36oaEdvvQoFer+VsgHpTF3VDjYAdwxmy+sfJG+vmnKq9dImyy7EQcYJif4l7wGAMv0bn/Rc uIV37t6GLeRHOKfy0KvSoSMuAPNZbcu7DyjHSyrsHdMh4ZNAi3RKFgyTeANE4FO/5LwFQ9kSr+IpL 6oEaSmA2S3f19F65CtAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnf1l-00000007lXp-3l8E; Thu, 27 Feb 2025 14:38:17 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tndTc-00000007RoS-43jz for linux-mtd@lists.infradead.org; Thu, 27 Feb 2025 12:58:58 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0E66641CFD; Thu, 27 Feb 2025 12:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740661132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTE06Wbb2OM49gD1uO4FAF7+EIpzsE2Tg148tPUePjg=; b=TiGeMy2gnXL56gcnNnUa6+KDH4trUyUhrlGUFxpqCwRLZamVhG/3XjaPYG2wBQN1/I8juu rswIjddQLWYeZqrnvkN31X/PeHOM7jaeMDYSrPdfyhX8DKkzkUMPaPDtqWx+ENAMUcBebL 1PTmrHPg0r3KzZJg3Dnm6byql9VtCpf05o/uiZjmAm/+8ZRghz3LePfAoGVdHU8aHnueTl pT429UjuA2yuP3MmgpbhmLCeM0gKTV2cKprlo3b0jXEZtF8R05g0u1iFsp57zprLRuxZUR yBOZzxXKZGrzGXdpiO8UrvjXLeXOZ3Qvw363iuni5bu/6balSCwNuUCyVOACNQ== From: Miquel Raynal To: Kamal Dasu Cc: florian.fainelli@broadcom.com, Brian Norris , Broadcom internal kernel review list , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Kamal Dasu Subject: Re: [PATCH] mtd: rawnand: brcmnand: fix PM resume warning In-Reply-To: <20250226225356.16380-1-kamal.dasu@broadcom.com> (Kamal Dasu's message of "Wed, 26 Feb 2025 17:53:09 -0500") References: <20250226225356.16380-1-kamal.dasu@broadcom.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Thu, 27 Feb 2025 13:58:49 +0100 Message-ID: <874j0fczna.fsf@bootlin.com> MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekjeehvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefoihhquhgvlhcutfgrhihnrghluceomhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepffeghfejtdefieeguddukedujeektdeihfelleeuieeuveehkedvleduheeivdefnecukfhppedvudejrdduuddvrddukeelrddukedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvddujedrudduvddrudekledrudekuddphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepledprhgtphhtthhopehkrghmrghlrdgurghsuhessghrohgruggtohhmrdgtohhmpdhrtghpthhtohepfhhlohhrihgrnhdrfhgrihhnvghllhhisegsrhhorggutghomhdrtghomhdprhgtphhtthhopegtohhmphhuthgvrhhsfhhorhhpvggrtggvsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsggtmhdqkhgvrhhnvghlqdhfvggvuggsrggtkhdqlhhishhtsegsrhhorggutghomhdrtghom hdprhgtphhtthhopehrihgthhgrrhgusehnohgurdgrthdprhgtphhtthhopehvihhgnhgvshhhrhesthhirdgtohhmpdhrtghpthhtoheplhhinhhugidqmhhtugeslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250227_045857_465454_9BF67333 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gS2FtYWwsCgpPbiAyNi8wMi8yMDI1IGF0IDE3OjUzOjA5IC0wNSwgS2FtYWwgRGFzdSA8 a2FtYWwuZGFzdUBicm9hZGNvbS5jb20+IHdyb3RlOgoKPiBGaXhlZCB3YXJuaW5nIGR1ZSB0byB1 bmludGlhbGl6ZWQgc3RydWN0IG5hbmRfb3BlcmF0aW9uIG9wLT5jcwo+IFdBUk5fT04ob3AtPmNz ID49IG5hbmRkZXZfbnRhcmdldHMoJmNoaXAtPmJhc2UpCj4KPiBbICAgMTQuNTg4NTIyXSAtLS0t LS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0KPiBbICAgMTQuNTg4NTI5XSBXQVJOSU5H OiBDUFU6IDAgUElEOiAxMzkyIGF0IGRyaXZlcnMvbXRkL25hbmQvcmF3L2ludGVybmFscy5oOjEz OSBuYW5kX3Jlc2V0X29wKzB4MWUwLzB4MWY4Cj4gWyAgIDE0LjU4ODU1M10gTW9kdWxlcyBsaW5r ZWQgaW46IGJkYyB1ZGNfY29yZQo+IFsgICAxNC41ODg1NzldIENQVTogMCBVSUQ6IDAgUElEOiAx MzkyIENvbW06IHJ0Y3dha2UgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgICA2LjE0LjAtcmM0 LWc1Mzk0ZWVhMTA2NTEgIzE2Cj4gWyAgIDE0LjU4ODU5MF0gVGFpbnRlZDogW1ddPVdBUk4KPiBb ICAgMTQuNTg4NTkzXSBIYXJkd2FyZSBuYW1lOiBCcm9hZGNvbSBTVEIgKEZsYXR0ZW5lZCBEZXZp Y2UgVHJlZSkKPiBbICAgMTQuNTg4NTk4XSBDYWxsIHRyYWNlOgo+IFsgICAxNC41ODg2MDRdICBk dW1wX2JhY2t0cmFjZSBmcm9tIHNob3dfc3RhY2srMHgxOC8weDFjCj4gWyAgIDE0LjU4ODYyMl0g IHI3OjAwMDAwMDA5IHI2OjAwMDAwMDhiIHI1OjYwMDAwMTUzIHI0OmMwZmE1NThjCj4gWyAgIDE0 LjU4ODYyNV0gIHNob3dfc3RhY2sgZnJvbSBkdW1wX3N0YWNrX2x2bCsweDcwLzB4N2MKPiBbICAg MTQuNTg4NjM5XSAgZHVtcF9zdGFja19sdmwgZnJvbSBkdW1wX3N0YWNrKzB4MTgvMHgxYwo+IFsg ICAxNC41ODg2NTNdICByNTpjMDhkNDBiMCByNDpjMTAwM2NiMAo+IFsgICAxNC41ODg2NTZdICBk dW1wX3N0YWNrIGZyb20gX193YXJuKzB4ODQvMHhlNAo+IFsgICAxNC41ODg2NjhdICBfX3dhcm4g ZnJvbSB3YXJuX3Nsb3dwYXRoX2ZtdCsweDE4Yy8weDE5NAo+IFsgICAxNC41ODg2NzhdICByNzpj MDhkNDBiMCByNjpjMTAwM2NiMCByNTowMDAwMDAwMCByNDowMDAwMDAwMAo+IFsgICAxNC41ODg2 ODFdICB3YXJuX3Nsb3dwYXRoX2ZtdCBmcm9tIG5hbmRfcmVzZXRfb3ArMHgxZTAvMHgxZjgKPiBb ICAgMTQuNTg4Njk1XSAgcjg6NzBjNDBkZmYgcjc6ODk3MDVmNDEgcjY6MzZiNGE1OTcgcjU6YzI2 Yzk0NDQgcjQ6YzI2YjAwNDgKPiBbICAgMTQuNTg4Njk3XSAgbmFuZF9yZXNldF9vcCBmcm9tIGJy Y21uYW5kX3Jlc3VtZSsweDEzYy8weDE1MAo+IFsgICAxNC41ODg3MTRdICByOTowMDAwMDAwMCBy ODowMDAwMDAwMCByNzpjMjRmODAxMCByNjpjMjI4YTNmOCByNTpjMjZjOTRiYyByNDpjMjZiMDA0 MAo+IFsgICAxNC41ODg3MTddICBicmNtbmFuZF9yZXN1bWUgZnJvbSBwbGF0Zm9ybV9wbV9yZXN1 bWUrMHgzNC8weDU0Cj4gWyAgIDE0LjU4ODczNV0gIHI1OjAwMDAwMDEwIHI0OmMwODQwYTUwCj4g WyAgIDE0LjU4ODczOF0gIHBsYXRmb3JtX3BtX3Jlc3VtZSBmcm9tIGRwbV9ydW5fY2FsbGJhY2sr MHg1Yy8weDE0Ywo+IFsgICAxNC41ODg3NTddICBkcG1fcnVuX2NhbGxiYWNrIGZyb20gZGV2aWNl X3Jlc3VtZSsweGMwLzB4MzI0Cj4gWyAgIDE0LjU4ODc3Nl0gIHI5OmMyNGY4MDU0IHI4OmMyNGY4 MGEwIHI3OjAwMDAwMDAwIHI2OjAwMDAwMDAwIHI1OjAwMDAwMDEwIHI0OmMyNGY4MDEwCj4gWyAg IDE0LjU4ODc3OV0gIGRldmljZV9yZXN1bWUgZnJvbSBkcG1fcmVzdW1lKzB4MTMwLzB4MTYwCj4g WyAgIDE0LjU4ODc5OV0gIHI5OmMyMjUzOWU0IHI4OjAwMDAwMDEwIHI3OmMyMmJlYmIwIHI2OmMy NGY4MDEwIHI1OmMyMjUzOWRjIHI0OmMyMjUzOWIwCj4gWyAgIDE0LjU4ODgwMl0gIGRwbV9yZXN1 bWUgZnJvbSBkcG1fcmVzdW1lX2VuZCsweDE0LzB4MjAKPiBbICAgMTQuNTg4ODIyXSAgcjEwOmMy MjA0ZTQwIHI5OjAwMDAwMDAwIHI4OmMyMjhhM2ZjIHI3OjAwMDAwMDAwIHI2OjAwMDAwMDAzIHI1 OmMyMjhhNDE0Cj4gWyAgIDE0LjU4ODgyNl0gIHI0OjAwMDAwMDEwCj4gWyAgIDE0LjU4ODgyOF0g IGRwbV9yZXN1bWVfZW5kIGZyb20gc3VzcGVuZF9kZXZpY2VzX2FuZF9lbnRlcisweDI3NC8weDZm OAo+IFsgICAxNC41ODg4NDhdICByNTpjMjI4YTQxNCByNDowMDAwMDAwMAo+IFsgICAxNC41ODg4 NTFdICBzdXNwZW5kX2RldmljZXNfYW5kX2VudGVyIGZyb20gcG1fc3VzcGVuZCsweDIyOC8weDJi Ywo+IFsgICAxNC41ODg4NjhdICByMTA6YzM1MDI5MTAgcjk6YzM1MDFmNDAgcjg6MDAwMDAwMDQg cjc6YzIyOGE0MzggcjY6YzBmOTVlMTggcjU6MDAwMDAwMDAKPiBbICAgMTQuNTg4ODcxXSAgcjQ6 MDAwMDAwMDMKPiBbICAgMTQuNTg4ODc0XSAgcG1fc3VzcGVuZCBmcm9tIHN0YXRlX3N0b3JlKzB4 NzQvMHhkMAo+IFsgICAxNC41ODg4ODldICByNzpjMjI4YTQzOCByNjpjMGY5MzRjOCByNTowMDAw MDAwMyByNDowMDAwMDAwMwo+IFsgICAxNC41ODg4OTJdICBzdGF0ZV9zdG9yZSBmcm9tIGtvYmpf YXR0cl9zdG9yZSsweDFjLzB4MjgKPiBbICAgMTQuNTg4OTEzXSAgcjk6MDAwMDAwMDAgcjg6MDAw MDAwMDAgcjc6ZjA5ZjlmMDggcjY6MDAwMDAwMDQgcjU6YzM1MDI5MDAgcjQ6YzAyODMyNTAKPiBb ICAgMTQuNTg4OTE2XSAga29ial9hdHRyX3N0b3JlIGZyb20gc3lzZnNfa2Zfd3JpdGUrMHg0MC8w eDRjCj4gWyAgIDE0LjU4ODkzNl0gIHI1OmMzNTAyOTAwIHI0OmMwZDkyYTQ4Cj4gWyAgIDE0LjU4 ODkzOV0gIHN5c2ZzX2tmX3dyaXRlIGZyb20ga2VybmZzX2ZvcF93cml0ZV9pdGVyKzB4MTA0LzB4 MWYwCj4gWyAgIDE0LjU4ODk1Nl0gIHI1OmMzNTAyOTAwIHI0OmMzNTAxZjQwCj4gWyAgIDE0LjU4 ODk2MF0gIGtlcm5mc19mb3Bfd3JpdGVfaXRlciBmcm9tIHZmc193cml0ZSsweDI1MC8weDQyMAo+ IFsgICAxNC41ODg5ODBdICByMTA6YzBlMTRiNDggcjk6MDAwMDAwMDAgcjg6YzI1ZjU3ODAgcjc6 MDA0NDMzOTggcjY6ZjA5ZjlmNjggcjU6YzM0ZjdmMDAKPiBbICAgMTQuNTg4OTgzXSAgcjQ6YzA0 MmE4OGMKPiBbICAgMTQuNTg4OTg3XSAgdmZzX3dyaXRlIGZyb20ga3N5c193cml0ZSsweDc0LzB4 ZTQKPiBbICAgMTQuNTg5MDA1XSAgcjEwOjAwMDAwMDA0IHI5OmMyNWY1NzgwIHI4OmMwMjAwMmYw IHI3OjAwMDAwMDAwIHI2OjAwMDAwMDAwIHI1OmMzNGY3ZjAwCj4gWyAgIDE0LjU4OTAwOF0gIHI0 OmMzNGY3ZjAwCj4gWyAgIDE0LjU4OTAxMV0gIGtzeXNfd3JpdGUgZnJvbSBzeXNfd3JpdGUrMHgx MC8weDE0Cj4gWyAgIDE0LjU4OTAyOV0gIHI3OjAwMDAwMDA0IHI2OjAwNDQyMWMwIHI1OjAwNDQz Mzk4IHI0OjAwMDAwMDA0Cj4gWyAgIDE0LjU4OTAzMl0gIHN5c193cml0ZSBmcm9tIHJldF9mYXN0 X3N5c2NhbGwrMHgwLzB4NWMKPiBbICAgMTQuNTg5MDQ0XSBFeGNlcHRpb24gc3RhY2soMHhmMDlm OWZhOCB0byAweGYwOWY5ZmYwKQo+IFsgICAxNC41ODkwNTBdIDlmYTA6ICAgICAgICAgICAgICAg ICAgIDAwMDAwMDA0IDAwNDQzMzk4IDAwMDAwMDA0IDAwNDQzMzk4IDAwMDAwMDA0IDAwMDAwMDAx Cj4gWyAgIDE0LjU4OTA1Nl0gOWZjMDogMDAwMDAwMDQgMDA0NDMzOTggMDA0NDIxYzAgMDAwMDAw MDQgYjZlY2JkNTggMDAwMDAwMDggYmViZmJjMzggMDA0M2ViNzgKPiBbICAgMTQuNTg5MDYyXSA5 ZmUwOiAwMDQ0MGViMCBiZWJmYmFmOCBiNmRlMThhMCBiNmU1NzllOAo+IFsgICAxNC41ODkwNjVd IC0tLVsgZW5kIHRyYWNlIDAwMDAwMDAwMDAwMDAwMDAgXS0tLQo+Cj4gVGhlIGZpeCB1c2VzIHRo ZSBoaWdoZXIgbGV2ZWwgbmFuZF9yZXNldChjaGlwLCBjaGlwbnIpOyB3aGVyZSBjaGlwbnIgPSAw LCB3aGVuCj4gZG9pbmcgUE0gcmVzdW1lIG9wZXJhdGlvbiBpbiBjb21wbGlhbmNlIHdpdGggdGhl IGNvbnRyb2xsZXIgc3VwcG9ydCBmb3Igc2luZ2xlIGRpZQo+IG5hbmQgY2hpcC4gVGhpcyBlbnN1 cmVzIHRoYXQgdGhlIG9wLT5jcyBpcyBpbml0aWFsaXplZCBiZWZvcmUgY2FsbGluZyB0aGUKPiBu YW5kX3Jlc2V0X29wKCkuCgpXaGlsZSBJIGJlbGlldmUgdGhlIGZpeCBpcyBjb3JyZWN0LCB0aGUg ZXhwbGFuYXRpb24gaXMgcGFydGlhbGx5CnNhdGlzZnlpbmcgYmVjYXVzZSB5b3UgZm9jdXMgb24g dGhlIFdhcm5pbmcgcmVwb3J0ZWQgYWJvdmUgKHdoaWNoIGluZGVlZApuZWVkcyBmaXhpbmcpIHdo ZXJlYXMgdGhlIGJpZ2dlciBwcm9ibGVtIHlvdSBoYXZlIGlzIHRoZSBmYWN0IHRoYXQgeW91cgpO QU5EIGNoaXAgaXMgcHJvYmFibHkgbm8gbG9uZ2VyIGluIHN5bmMgdGltaW5nIHdpc2Ugd2l0aCB0 aGUKaG9zdC4gU3dpdGNoaW5nIGZyb20gbmFuZF9yZXNldF9vcCgpIHRvIG5hbmRfcmVzZXQoKSBp bXBsaWVzIG1vcmUgdGhhbgpqdXN0IHNldHRpbmcgdGhlIGNzIGZpZWxkLCBpdCBhbHNvIHJlY29u ZmlndXJlcyB0aGUgZGF0YSBpbnRlcmZhY2UKKGllLiB0aGUgdGltaW5ncykuIEkgYmVsaWV2ZSB0 aGlzIGlzIGltcG9ydGFudCBlbm91Z2ggdG8gYmUgbWVudGlvbmVkLgoKPiBGaXhlcyA6IDk3ZDkw ZGE4YTg4NiAoIm10ZDogbmFuZDogcHJvdmlkZSBzZXZlcmFsIGhlbHBlcnMgdG8gZG8gY29tbW9u IE5BTkQgb3BlcmF0aW9ucyIpCgpQbGVhc2UgYWRkIENjOiBzdGFibGVAIGhlcmUuCgo+IFNpZ25l ZC1vZmYtYnk6IEthbWFsIERhc3UgPGtkYXN1QGJyb2FkY29tLmNvbT4KClRoYW5rcywKTWlxdcOo bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 540F222D7B2 for ; Thu, 27 Feb 2025 12:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740661137; cv=none; b=oHIrUfe/5TQokXP8OvegzBeHEFNzmsCvYDJH0n2E6cdD0pB30EASIr7Or4Jm+wrj3Qez8mhgUOorMUT24bD6AaJLH2YqCE6zTZFDJ3Oz+ar8H+0MBWHGQmQGJ94IBesexG41b+ylGA5t2CObA76sPINBRvn481VVEhpT3a70sWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740661137; c=relaxed/simple; bh=dT5L81QZd9ml7f0jsryPGQHSjzeNso4RNMuuRronL0M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iUr0FxAQLfdD15z/gAseE+aLl2jYhDrCs/VuRfHuOsUGKXYSuElp1W7qlJSvciQukzt2wrEkY25J3D5ru/LFco1X569UDYJHdT0lN3mWQpngho2Pjr+2P2nssDlhUav3uZoJMmrTL9+OSabxqrlrOY3hiAQzENhNqPJlW4Rodo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=TiGeMy2g; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TiGeMy2g" Received: by mail.gandi.net (Postfix) with ESMTPSA id 0E66641CFD; Thu, 27 Feb 2025 12:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740661132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTE06Wbb2OM49gD1uO4FAF7+EIpzsE2Tg148tPUePjg=; b=TiGeMy2gnXL56gcnNnUa6+KDH4trUyUhrlGUFxpqCwRLZamVhG/3XjaPYG2wBQN1/I8juu rswIjddQLWYeZqrnvkN31X/PeHOM7jaeMDYSrPdfyhX8DKkzkUMPaPDtqWx+ENAMUcBebL 1PTmrHPg0r3KzZJg3Dnm6byql9VtCpf05o/uiZjmAm/+8ZRghz3LePfAoGVdHU8aHnueTl pT429UjuA2yuP3MmgpbhmLCeM0gKTV2cKprlo3b0jXEZtF8R05g0u1iFsp57zprLRuxZUR yBOZzxXKZGrzGXdpiO8UrvjXLeXOZ3Qvw363iuni5bu/6balSCwNuUCyVOACNQ== From: Miquel Raynal To: Kamal Dasu Cc: florian.fainelli@broadcom.com, Brian Norris , Broadcom internal kernel review list , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Kamal Dasu Subject: Re: [PATCH] mtd: rawnand: brcmnand: fix PM resume warning In-Reply-To: <20250226225356.16380-1-kamal.dasu@broadcom.com> (Kamal Dasu's message of "Wed, 26 Feb 2025 17:53:09 -0500") References: <20250226225356.16380-1-kamal.dasu@broadcom.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Thu, 27 Feb 2025 13:58:49 +0100 Message-ID: <874j0fczna.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekjeehvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffgffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefoihhquhgvlhcutfgrhihnrghluceomhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepffeghfejtdefieeguddukedujeektdeihfelleeuieeuveehkedvleduheeivdefnecukfhppedvudejrdduuddvrddukeelrddukedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvddujedrudduvddrudekledrudekuddphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhiqhhuvghlrdhrrgihnhgrlhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepledprhgtphhtthhopehkrghmrghlrdgurghsuhessghrohgruggtohhmrdgtohhmpdhrtghpthhtohepfhhlohhrihgrnhdrfhgrihhnvghllhhisegsrhhorggutghomhdrtghomhdprhgtphhtthhopegtohhmphhuthgvrhhsfhhorhhpvggrtggvsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsggtmhdqkhgvrhhnvghlqdhfvggvuggsrggtkhdqlhhishhtsegsrhhorggutghomhdrtghom hdprhgtphhtthhopehrihgthhgrrhgusehnohgurdgrthdprhgtphhtthhopehvihhgnhgvshhhrhesthhirdgtohhmpdhrtghpthhtoheplhhinhhugidqmhhtugeslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-GND-Sasl: miquel.raynal@bootlin.com Hello Kamal, On 26/02/2025 at 17:53:09 -05, Kamal Dasu wrote: > Fixed warning due to unintialized struct nand_operation op->cs > WARN_ON(op->cs >=3D nanddev_ntargets(&chip->base) > > [ 14.588522] ------------[ cut here ]------------ > [ 14.588529] WARNING: CPU: 0 PID: 1392 at drivers/mtd/nand/raw/internal= s.h:139 nand_reset_op+0x1e0/0x1f8 > [ 14.588553] Modules linked in: bdc udc_core > [ 14.588579] CPU: 0 UID: 0 PID: 1392 Comm: rtcwake Tainted: G W = 6.14.0-rc4-g5394eea10651 #16 > [ 14.588590] Tainted: [W]=3DWARN > [ 14.588593] Hardware name: Broadcom STB (Flattened Device Tree) > [ 14.588598] Call trace: > [ 14.588604] dump_backtrace from show_stack+0x18/0x1c > [ 14.588622] r7:00000009 r6:0000008b r5:60000153 r4:c0fa558c > [ 14.588625] show_stack from dump_stack_lvl+0x70/0x7c > [ 14.588639] dump_stack_lvl from dump_stack+0x18/0x1c > [ 14.588653] r5:c08d40b0 r4:c1003cb0 > [ 14.588656] dump_stack from __warn+0x84/0xe4 > [ 14.588668] __warn from warn_slowpath_fmt+0x18c/0x194 > [ 14.588678] r7:c08d40b0 r6:c1003cb0 r5:00000000 r4:00000000 > [ 14.588681] warn_slowpath_fmt from nand_reset_op+0x1e0/0x1f8 > [ 14.588695] r8:70c40dff r7:89705f41 r6:36b4a597 r5:c26c9444 r4:c26b00= 48 > [ 14.588697] nand_reset_op from brcmnand_resume+0x13c/0x150 > [ 14.588714] r9:00000000 r8:00000000 r7:c24f8010 r6:c228a3f8 r5:c26c94= bc r4:c26b0040 > [ 14.588717] brcmnand_resume from platform_pm_resume+0x34/0x54 > [ 14.588735] r5:00000010 r4:c0840a50 > [ 14.588738] platform_pm_resume from dpm_run_callback+0x5c/0x14c > [ 14.588757] dpm_run_callback from device_resume+0xc0/0x324 > [ 14.588776] r9:c24f8054 r8:c24f80a0 r7:00000000 r6:00000000 r5:000000= 10 r4:c24f8010 > [ 14.588779] device_resume from dpm_resume+0x130/0x160 > [ 14.588799] r9:c22539e4 r8:00000010 r7:c22bebb0 r6:c24f8010 r5:c22539= dc r4:c22539b0 > [ 14.588802] dpm_resume from dpm_resume_end+0x14/0x20 > [ 14.588822] r10:c2204e40 r9:00000000 r8:c228a3fc r7:00000000 r6:00000= 003 r5:c228a414 > [ 14.588826] r4:00000010 > [ 14.588828] dpm_resume_end from suspend_devices_and_enter+0x274/0x6f8 > [ 14.588848] r5:c228a414 r4:00000000 > [ 14.588851] suspend_devices_and_enter from pm_suspend+0x228/0x2bc > [ 14.588868] r10:c3502910 r9:c3501f40 r8:00000004 r7:c228a438 r6:c0f95= e18 r5:00000000 > [ 14.588871] r4:00000003 > [ 14.588874] pm_suspend from state_store+0x74/0xd0 > [ 14.588889] r7:c228a438 r6:c0f934c8 r5:00000003 r4:00000003 > [ 14.588892] state_store from kobj_attr_store+0x1c/0x28 > [ 14.588913] r9:00000000 r8:00000000 r7:f09f9f08 r6:00000004 r5:c35029= 00 r4:c0283250 > [ 14.588916] kobj_attr_store from sysfs_kf_write+0x40/0x4c > [ 14.588936] r5:c3502900 r4:c0d92a48 > [ 14.588939] sysfs_kf_write from kernfs_fop_write_iter+0x104/0x1f0 > [ 14.588956] r5:c3502900 r4:c3501f40 > [ 14.588960] kernfs_fop_write_iter from vfs_write+0x250/0x420 > [ 14.588980] r10:c0e14b48 r9:00000000 r8:c25f5780 r7:00443398 r6:f09f9= f68 r5:c34f7f00 > [ 14.588983] r4:c042a88c > [ 14.588987] vfs_write from ksys_write+0x74/0xe4 > [ 14.589005] r10:00000004 r9:c25f5780 r8:c02002f0 r7:00000000 r6:00000= 000 r5:c34f7f00 > [ 14.589008] r4:c34f7f00 > [ 14.589011] ksys_write from sys_write+0x10/0x14 > [ 14.589029] r7:00000004 r6:004421c0 r5:00443398 r4:00000004 > [ 14.589032] sys_write from ret_fast_syscall+0x0/0x5c > [ 14.589044] Exception stack(0xf09f9fa8 to 0xf09f9ff0) > [ 14.589050] 9fa0: 00000004 00443398 00000004 0044339= 8 00000004 00000001 > [ 14.589056] 9fc0: 00000004 00443398 004421c0 00000004 b6ecbd58 0000000= 8 bebfbc38 0043eb78 > [ 14.589062] 9fe0: 00440eb0 bebfbaf8 b6de18a0 b6e579e8 > [ 14.589065] ---[ end trace 0000000000000000 ]--- > > The fix uses the higher level nand_reset(chip, chipnr); where chipnr =3D = 0, when > doing PM resume operation in compliance with the controller support for s= ingle die > nand chip. This ensures that the op->cs is initialized before calling the > nand_reset_op(). While I believe the fix is correct, the explanation is partially satisfying because you focus on the Warning reported above (which indeed needs fixing) whereas the bigger problem you have is the fact that your NAND chip is probably no longer in sync timing wise with the host. Switching from nand_reset_op() to nand_reset() implies more than just setting the cs field, it also reconfigures the data interface (ie. the timings). I believe this is important enough to be mentioned. > Fixes : 97d90da8a886 ("mtd: nand: provide several helpers to do common NA= ND operations") Please add Cc: stable@ here. > Signed-off-by: Kamal Dasu Thanks, Miqu=C3=A8l