From: Thomas Gleixner <tglx@linutronix.de>
To: Guenter Roeck <linux@roeck-us.net>, Nam Cao <namcao@linutronix.de>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
linux-kernel@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 23/31] watchdog: Switch to use hrtimer_setup()
Date: Thu, 13 Feb 2025 12:16:23 +0100 [thread overview]
Message-ID: <874j0yksc8.ffs@tglx> (raw)
In-Reply-To: <882031d8-5b8b-455c-9f5e-90090408304e@roeck-us.net>
On Tue, Feb 11 2025 at 08:16, Guenter Roeck wrote:
> On Wed, Feb 05, 2025 at 11:39:07AM +0100, Nam Cao wrote:
>> hrtimer_setup() takes the callback function pointer as argument and
>> initializes the timer completely.
>>
>> Replace hrtimer_init() and the open coded initialization of
>> hrtimer::function with the new setup mechanism.
>>
>> Patch was created by using Coccinelle.
>>
>> Signed-off-by: Nam Cao <namcao@linutronix.de>
>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
>> Cc: linux-watchdog@vger.kernel.org
>> ---
>
> Change log missing.
I read the above as a change log, but _I_ might be missing something.
> I am also personally not a friend of changing
> multiple drivers in a single patch for changes like this. That makes
> it all but impossible to revert one of the driver changes if it was
> wrong without reverting everything.
Come on. This is a purely mechanical change which is fully equivalent,
so splitting it up further is just increasing patch count for no value.
Thanks,
tglx
next prev parent reply other threads:[~2025-02-13 11:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 10:38 [PATCH v2 00/31] hrtimers: Consolidate hrtimer initialization - Part 2 Nam Cao
2025-02-05 10:38 ` [PATCH v2 01/31] KVM: MIPS: Switch to use hrtimer_setup() Nam Cao
2025-02-05 10:38 ` [PATCH v2 02/31] KVM: PPC: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 03/31] KVM: s390: " Nam Cao
2025-02-07 10:29 ` Christian Borntraeger
2025-02-05 10:38 ` [PATCH v2 04/31] KVM: x86: " Nam Cao
2025-02-06 15:33 ` Sean Christopherson
2025-02-05 10:38 ` [PATCH v2 05/31] KVM: arm64: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 06/31] LoongArch: KVM: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 07/31] riscv: kvm: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 08/31] ARM: imx: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 09/31] ARM: 8611/1: l2x0: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 10/31] powerpc/watchdog: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 11/31] perf/x86: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 12/31] s390/ap_bus: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 13/31] sched: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 14/31] mm/slab: " Nam Cao
2025-02-05 10:38 ` [PATCH v2 15/31] lib: test_objpool: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 16/31] io_uring/timeout: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 17/31] fork: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 18/31] perf: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 19/31] timerfd: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 20/31] time: Switch to hrtimer_setup() Nam Cao
2025-02-05 10:39 ` [PATCH v2 21/31] bpf: Switch to use hrtimer_setup() Nam Cao
2025-02-05 10:39 ` [PATCH v2 22/31] ubifs: " Nam Cao
2025-02-10 19:36 ` Richard Weinberger
2025-02-05 10:39 ` [PATCH v2 23/31] watchdog: " Nam Cao
2025-02-11 16:16 ` Guenter Roeck
2025-02-13 11:16 ` Thomas Gleixner [this message]
2025-02-13 12:24 ` Guenter Roeck
2025-02-13 13:43 ` Nam Cao
2025-02-05 10:39 ` [PATCH v2 24/31] tracing/osnoise: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 25/31] block, bfq: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 26/31] ata: pata_octeon_cf: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 27/31] blk_iocost: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 28/31] PM: runtime: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 29/31] PM / devfreq: rockchip-dfi: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 30/31] null_blk: " Nam Cao
2025-02-05 10:39 ` [PATCH v2 31/31] hwrng: timeriomem: " Nam Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j0yksc8.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=namcao@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.