Re: [PATCH] MAINTAINER: Add a maintainer for CPR

[Fabiano Rosas <farosas@suse.de>]

Steven Sistare <steven.sistare@oracle.com> writes:

> On 2/4/2025 8:42 AM, Cédric Le Goater wrote:
>> On 2/4/25 14:31, Steven Sistare wrote:
>>> Hi Cedric, CPR is a mode of live migration, integrated so closely that
>>> it makes more sense for the migration maintainers to maintain it, and
>>> consult me if/when necessary.  "migration" appears in 4 of the 5 paths
>>> you list below.
>> 
>> CPR is growing with the recent proposal and it is a large enough
>> feature to have its own maintainer IMHO.
>> 
>> Should we add cpr* files under the migration subsystem then ?
>
> Sure, I'll do that in V2 for the vfio series.
>
> - Steve
>
>>> On 2/4/2025 3:28 AM, Cédric Le Goater wrote:
>>>> The CPR feature was added in QEMU 9.0 and it lacks a maintainer.
>>>> Propose the main contributor to become one.
>>>>
>>>> Cc: Steve Sistare <steven.sistare@oracle.com>
>>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>>> ---
>>>>   MAINTAINERS | 9 +++++++++
>>>>   1 file changed, 9 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index db8c41fbe0f9..efb9da02f142 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -2943,6 +2943,15 @@ F: include/qemu/co-shared-resource.h
>>>>   T: git https://gitlab.com/jsnow/qemu.git jobs
>>>>   T: git https://gitlab.com/vsementsov/qemu.git block
>>>> +CheckPoint and Restart (CPR)
>>>> +M: Steve Sistare <steven.sistare@oracle.com>
>>>> +S: Supported
>>>> +F: hw/vfio/cpr*
>>>> +F: include/migration/cpr.h
>>>> +F: migration/cpr*
>>>> +F: tests/qtest/migration/cpr*
>>>> +F: docs/devel/migration/CPR.rst
>>>> +
>>>>   Compute Express Link
>>>>   M: Jonathan Cameron <jonathan.cameron@huawei.com>
>>>>   R: Fan Ni <fan.ni@samsung.com>
>>>
>> 

We've made our bed years ago when it was decided that cpr should use
migration facilities. I wasn't even around at the time, but I tend to
honor decisions made by previous maintainers. So I'm ok with leaving CPR
under the migration tree.

However I agree with the general sentiment of Cédric's email. CPR is
becoming a big thing and we might run into resource issues for its
maintenance. As always, we do this on a best-effort basis and if the
workload starts to become an issue we'll have to ask for help or
reconsider the feature's status in the codebase.