From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Clement Ramirez <clement@clementramirez.fr>
Subject: Re: [Buildroot] [PATCH 3/4] package/busybox: fix hwclock build issue on RISC-V 32-bit musl configs
Date: Tue, 04 Feb 2025 09:55:37 +0100 [thread overview]
Message-ID: <874j1aqeba.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20250203142748.1135655-4-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Mon, 3 Feb 2025 15:27:42 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> Take a patch from meta-riscv, which was submitted upstream by Khem Raj
> to fix a build issue on RISC-V 32-bit musl configurations. This issue
> has been discussed with musl developers who believe this is a Busybox
> issue. The patch from Khem works around the issue by making it a
> runtime failure just affecting hwclock on RISC-V 32-bit musl instead
> of a build failure. The correct fix is not really clear, as there
> seems to be a disagreement between Busybox people and musl people on
> what the C library settimeofday() function should do, and that's why
> Busybox is bypassing settimeofday() on musl by making a direct system
> call, except this system call doesn't exist on RISC-V 32-bit.
> In the mean time, this patch fixes the long standing Gitlab CI issue:
> - tests.toolchain.test_external_bootlin.TestExternalToolchainBootlinRiscv32ilp32dMuslStable
> https://gitlab.com/buildroot.org/buildroot/-/jobs/8954291684
> - tests.toolchain.test_external_bootlin.TestExternalToolchainBootlinRiscv32ilp32dMuslBleedingEdge
> https://gitlab.com/buildroot.org/buildroot/-/jobs/8954291683
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Seems messy, but OK - Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-02-04 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 14:27 [Buildroot] [PATCH 0/4] Fix Busybox CVEs and bump to 1.37.0 Thomas Petazzoni via buildroot
2025-02-03 14:27 ` [Buildroot] [PATCH 1/4] package/busybox: fix patch 0009 formatting Thomas Petazzoni via buildroot
2025-02-04 8:52 ` Peter Korsgaard
2025-02-04 14:58 ` Peter Korsgaard
2025-02-03 14:27 ` [Buildroot] [PATCH 2/4] package/busybox: fix pending CVEs Thomas Petazzoni via buildroot
2025-02-04 8:53 ` Peter Korsgaard
2025-02-04 14:59 ` Peter Korsgaard
2025-02-03 14:27 ` [Buildroot] [PATCH 3/4] package/busybox: fix hwclock build issue on RISC-V 32-bit musl configs Thomas Petazzoni via buildroot
2025-02-04 8:55 ` Peter Korsgaard [this message]
2025-02-04 14:59 ` Peter Korsgaard
2025-02-03 14:27 ` [Buildroot] [PATCH 4/4] package/busybox bump version to 1.37.0 Thomas Petazzoni via buildroot
2025-02-04 8:56 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j1aqeba.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=clement@clementramirez.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.