All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jackie Dong <xy-jackie@139.com>
Cc: perex@perex.cz, tiwai@suse.com, bo.liu@senarytech.com,
	kovalev@altlinux.org, me@oldherl.one, jaroslaw.janik@gmail.com,
	songxiebing@kylinos.cn, cs@tuxedo.de, kailang@realtek.com,
	sbinding@opensource.cirrus.com, simont@opensource.cirrus.com,
	josh@joshuagrisham.com, rf@opensource.cirrus.com,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, dongeg1@lenovo.com,
	Mark Pearson <mpearson-lenovo@squebb.ca>
Subject: Re: [PATCH v3] ALSA: hda: Support for Ideapad hotkey mute LEDs
Date: Wed, 15 Jan 2025 17:00:30 +0100	[thread overview]
Message-ID: <874j20jcdd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250115154811.11869-1-xy-jackie@139.com>

On Wed, 15 Jan 2025 16:48:11 +0100,
Jackie Dong wrote:
> 
> 
> New ideapad helper file with support for handling FN key mute LEDs.
> Update conexant and realtec codec to add LED support.
> 
> Suggested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Jackie Dong  <xy-jackie@139.com>

It's almost fine, just one minor thing:

> @@ -11130,6 +11146,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC290_FIXUP_MONO_SPEAKERS_HSJACK, .name = "mono-speakers"},
>  	{.id = ALC290_FIXUP_SUBWOOFER_HSJACK, .name = "alc290-subwoofer"},
>  	{.id = ALC269_FIXUP_THINKPAD_ACPI, .name = "thinkpad"},
> +	{.id = ALC269_FIXUP_LENOVO_XPAD_ACPI, .name = "lenovo xpad led"},

The model string shouldn't contain a space.  It'd be too difficult to
specify in the boot option.  Use a hyphen instead.


thanks,

Takashi

      reply	other threads:[~2025-01-15 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15 15:48 [PATCH v3] ALSA: hda: Support for Ideapad hotkey mute LEDs Jackie Dong
2025-01-15 16:00 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j20jcdd.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bo.liu@senarytech.com \
    --cc=cs@tuxedo.de \
    --cc=dongeg1@lenovo.com \
    --cc=jaroslaw.janik@gmail.com \
    --cc=josh@joshuagrisham.com \
    --cc=kailang@realtek.com \
    --cc=kovalev@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=me@oldherl.one \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rf@opensource.cirrus.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=simont@opensource.cirrus.com \
    --cc=songxiebing@kylinos.cn \
    --cc=tiwai@suse.com \
    --cc=xy-jackie@139.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.