From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09EF71FF7CF; Tue, 3 Dec 2024 20:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733259337; cv=none; b=Ipk69puueS6NY2t3Q0/O9YebH3XwOHA8zow2+v7pF+jhkBIjMzP2tQtz87o2hXlDbv12PkxoTKQpBqbXi3OsAc/JWeGTfP1hTA9tHQ5t1eUSZeTCpsYQQrnxj6U0OYFHnfzbAPy8PZoDWsodhiQBcOhT1lhir/IUs6/mM195L+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733259337; c=relaxed/simple; bh=1Vw7nq1aQDtWvQcv5ozrIWgauqOHp4Xst17oCDS5tdk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=beRRvKuOuzx1Qrymu7zbaXASFe6KQlIShNXPRyjFMXtcwFfkE4T4xv0X7ihKsXLpnRAiHrAQ0m7Tp3q3FwZUaKbt2r3gnxRbKJ/0qMxwv/Sowy0TqlGb16bNcfXaSUWKfRnbgw6cCMuEO2jUcZCp6eRxv2URSXNXTtExvysrnJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=j3xZ7ZWF; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=uAjTjd9B; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="j3xZ7ZWF"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="uAjTjd9B" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1733259333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Vw7nq1aQDtWvQcv5ozrIWgauqOHp4Xst17oCDS5tdk=; b=j3xZ7ZWFy2hL7pxYlVg9MJz3602gMHQLlOCSB5IFE2hYgwHiCmqq6cOGP61nFHziKbygNE 7i/hkkxMjJQOQoOleLMCdadQNQwZBqWFs5xKvdodhd/CIeHlKTZIeeZlIs86hDBKoSKmDC u2HfN+VZPWy8mWBSBGZf9bBfGroISFgy4ikLuqlwQ9BIQ5asnEoDD8TxIjhK2jEUXdBSLn 06fypEp/Dcj14ZildKSQ3yIGDGBX8FXAJdPnrtKBiUJZ4PtzWoeKq+g0YNMdBJ6LwMYn9/ A2YrNMvXJpddF5IkFNxflgI62NoBk+vmQh1Yooegqi4Ibubo1nM5Yv9LN5pPjg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1733259333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Vw7nq1aQDtWvQcv5ozrIWgauqOHp4Xst17oCDS5tdk=; b=uAjTjd9Bdv3Hyb9oR+zF04wYQT7dpe7EddPHw1ftQ1vQ22n9XQU/tWMXhzuhbQ9TYsAtQ/ 3NcMtY0zXJK2JSCg== To: Anup Patel Cc: Andrew Jones , iommu@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, tjeznach@rivosinc.com, zong.li@sifive.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, atishp@atishpatra.org, alex.williamson@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Subject: Re: [RFC PATCH 01/15] irqchip/riscv-imsic: Use hierarchy to reach irq_set_affinity In-Reply-To: References: <20241114161845.502027-17-ajones@ventanamicro.com> <20241114161845.502027-18-ajones@ventanamicro.com> <87mshcub2u.ffs@tglx> Date: Tue, 03 Dec 2024 21:55:32 +0100 Message-ID: <874j3ktrjv.ffs@tglx> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Dec 03 2024 at 22:07, Anup Patel wrote: > On Tue, Dec 3, 2024 at 7:23=E2=80=AFPM Thomas Gleixner wrote: >> Sorry, I missed that when reviewing the original IMSIC MSI support. >> >> The whole IMSIC MSI support can be moved over to MSI LIB which makes all >> of this indirection go away and your intermediate domain will just fit >> in. >> >> Uncompiled patch below. If that works, it needs to be split up properly. >> >> Note, this removes the setup of the irq_retrigger callback, but that's >> fine because on hierarchical domains irq_chip_retrigger_hierarchy() is >> invoked anyway. See try_retrigger(). > > The IMSIC driver was merged one kernel release before common > MSI LIB was merged. Ah indeed. > We should definitely update the IMSIC driver to use MSI LIB, I will > try your suggested changes (below) and post a separate series. Pick up the delta patch I gave Andrew... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15C02E74AD5 for ; Tue, 3 Dec 2024 20:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klMLRdkHThxxCbvsDzQlo6navUCq4pUVOgQR0dCCyHI=; b=pspSYpxx8/FSma qLCn8r5aX//P+Si7CPtDYjb0D76RiW4aEjGl+OGaVCgJA8YWxzqciqb7iaLy3bokwdTCCKwc4IgGQ jJ3ymfHXYw7zgRoBdRfS03cfTIDJ84L5pqqrOcMzQ9uHShAlK/RwO9J4ZA7IFifQKStPKm8BOLzyD 6iSQciejE/52VFxUNwXK1WlcX98lIxFBYhrl08QqVRsDzYaHpZgKezC3yMmY6R2zglkS3oKTV8WI9 4LFIzP3UD8Os2Gz16M9pwd0xEJu0y1gx7pBv8hFd9bAEoM5IZzropSXFg9Ls66E8cQb0eT1aiYIOV /zOHqsBRXS/YJK7H1qpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tIZvo-0000000AhP3-3wcP; Tue, 03 Dec 2024 20:55:40 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tIZvl-0000000AhNg-2kdK; Tue, 03 Dec 2024 20:55:38 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1733259333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Vw7nq1aQDtWvQcv5ozrIWgauqOHp4Xst17oCDS5tdk=; b=j3xZ7ZWFy2hL7pxYlVg9MJz3602gMHQLlOCSB5IFE2hYgwHiCmqq6cOGP61nFHziKbygNE 7i/hkkxMjJQOQoOleLMCdadQNQwZBqWFs5xKvdodhd/CIeHlKTZIeeZlIs86hDBKoSKmDC u2HfN+VZPWy8mWBSBGZf9bBfGroISFgy4ikLuqlwQ9BIQ5asnEoDD8TxIjhK2jEUXdBSLn 06fypEp/Dcj14ZildKSQ3yIGDGBX8FXAJdPnrtKBiUJZ4PtzWoeKq+g0YNMdBJ6LwMYn9/ A2YrNMvXJpddF5IkFNxflgI62NoBk+vmQh1Yooegqi4Ibubo1nM5Yv9LN5pPjg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1733259333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Vw7nq1aQDtWvQcv5ozrIWgauqOHp4Xst17oCDS5tdk=; b=uAjTjd9Bdv3Hyb9oR+zF04wYQT7dpe7EddPHw1ftQ1vQ22n9XQU/tWMXhzuhbQ9TYsAtQ/ 3NcMtY0zXJK2JSCg== To: Anup Patel Cc: Andrew Jones , iommu@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, tjeznach@rivosinc.com, zong.li@sifive.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, atishp@atishpatra.org, alex.williamson@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Subject: Re: [RFC PATCH 01/15] irqchip/riscv-imsic: Use hierarchy to reach irq_set_affinity In-Reply-To: References: <20241114161845.502027-17-ajones@ventanamicro.com> <20241114161845.502027-18-ajones@ventanamicro.com> <87mshcub2u.ffs@tglx> Date: Tue, 03 Dec 2024 21:55:32 +0100 Message-ID: <874j3ktrjv.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241203_125537_833669_0D3711B2 X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBEZWMgMDMgMjAyNCBhdCAyMjowNywgQW51cCBQYXRlbCB3cm90ZToKPiBPbiBUdWUs IERlYyAzLCAyMDI0IGF0IDc6MjPigK9QTSBUaG9tYXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25p eC5kZT4gd3JvdGU6Cj4+IFNvcnJ5LCBJIG1pc3NlZCB0aGF0IHdoZW4gcmV2aWV3aW5nIHRoZSBv cmlnaW5hbCBJTVNJQyBNU0kgc3VwcG9ydC4KPj4KPj4gVGhlIHdob2xlIElNU0lDIE1TSSBzdXBw b3J0IGNhbiBiZSBtb3ZlZCBvdmVyIHRvIE1TSSBMSUIgd2hpY2ggbWFrZXMgYWxsCj4+IG9mIHRo aXMgaW5kaXJlY3Rpb24gZ28gYXdheSBhbmQgeW91ciBpbnRlcm1lZGlhdGUgZG9tYWluIHdpbGwg anVzdCBmaXQKPj4gaW4uCj4+Cj4+IFVuY29tcGlsZWQgcGF0Y2ggYmVsb3cuIElmIHRoYXQgd29y a3MsIGl0IG5lZWRzIHRvIGJlIHNwbGl0IHVwIHByb3Blcmx5Lgo+Pgo+PiBOb3RlLCB0aGlzIHJl bW92ZXMgdGhlIHNldHVwIG9mIHRoZSBpcnFfcmV0cmlnZ2VyIGNhbGxiYWNrLCBidXQgdGhhdCdz Cj4+IGZpbmUgYmVjYXVzZSBvbiBoaWVyYXJjaGljYWwgZG9tYWlucyBpcnFfY2hpcF9yZXRyaWdn ZXJfaGllcmFyY2h5KCkgaXMKPj4gaW52b2tlZCBhbnl3YXkuIFNlZSB0cnlfcmV0cmlnZ2VyKCku Cj4KPiBUaGUgSU1TSUMgZHJpdmVyIHdhcyBtZXJnZWQgb25lIGtlcm5lbCByZWxlYXNlIGJlZm9y ZSBjb21tb24KPiBNU0kgTElCIHdhcyBtZXJnZWQuCgpBaCBpbmRlZWQuCgo+IFdlIHNob3VsZCBk ZWZpbml0ZWx5IHVwZGF0ZSB0aGUgSU1TSUMgZHJpdmVyIHRvIHVzZSBNU0kgTElCLCBJIHdpbGwK PiB0cnkgeW91ciBzdWdnZXN0ZWQgY2hhbmdlcyAoYmVsb3cpIGFuZCBwb3N0IGEgc2VwYXJhdGUg c2VyaWVzLgoKUGljayB1cCB0aGUgZGVsdGEgcGF0Y2ggSSBnYXZlIEFuZHJldy4uLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=