Re: [PATCH v2 00/22] tests/qtest: migration-test refactoring

[Fabiano Rosas <farosas@suse.de>]

Peter Xu <peterx@redhat.com> writes:

> On Wed, Nov 13, 2024 at 04:46:08PM -0300, Fabiano Rosas wrote:
>> Fabiano Rosas (22):
>>   tests/qtest/migration: Fix indentations
>>   tests/qtest/migration: Standardize hook names
>>   tests/qtest/migration: Stop calling everything "test"
>>   tests/migration: Disambiguate guestperf vs. a-b
>>   tests/qtest/migration: Move bootfile code to its own file
>>   tests/qtest/migration: Move qmp helpers to a separate file
>>   tests/qtest/migration: Rename migration-helpers.c
>>   tests/qtest/migration: Move ufd_version_check to utils
>>   tests/qtest/migration: Move kvm_dirty_ring_supported to utils
>>   tests/qtest/migration: Isolate test initialization
>>   tests/qtest/migration: Move common test code
>>   tests/qtest/migration: Split TLS tests from migration-test.c
>>   tests/qtest/migration: Split compression tests from migration-test.c
>>   tests/qtest/migration: Split postcopy tests
>>   tests/qtest/migration: Split file tests
>>   tests/qtest/migration: Split precopy tests
>>   tests/qtest/migration: Split CPR tests
>>   tests/qtest/migration: Split validation tests + misc
>
> I'm not sure whether the above chunk could affect people reading the last
> four, which is the real meat.
>
> One thing we could do (but you can decide which you prefer..) is you can
> respin with the initial 18 patches, then we may get it in in the 1st 10.0
> pull.  It may conflict with some other series for sure, but it's
> unavoidable with such changes one way or another..

I can put them on top of migration-next, sure. As I said previously,
just point me at any conflicting series and I can provide a rebase.

> then when it's there we could repost the last four separately, so it
> can have a higher chance of getting some comments.  So I'll leave that
> to you to decide.

That's fine.

>
> I also wonder whether we could already move migration-test*.c into
> tests/qtest/migration/ too.

I'll look into it.