From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH] crypto: purge 'loaded' property that was documented as already removed
Date: Mon, 04 Nov 2024 09:09:40 +0100 [thread overview]
Message-ID: <874j4nzagr.fsf@pond.sub.org> (raw)
In-Reply-To: <20241030084718.2980247-1-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Wed, 30 Oct 2024 08:47:18 +0000")
Daniel P. Berrangé <berrange@redhat.com> writes:
> The 'loaded' property on TLS creds and secret objects was marked as
> deprected in 6.0.0 and then marked as removed in 7.1.0.
deprecated
Regarding "marked as removed": not quite. Its entry was moved from
docs/about/deprecated.rst to docs/about/removed-features.rst, but the
text there is "should simply be removed."
>
> Except it wasn't actually removed, it was just made read-only, while
> claiming it was removed. Finish the long overdue removal job.
>
> Fixes: 0310641c06dd5f7ea031b2b6170cb2edc63e4cea
I'm not sure it fixes something that was broken. Commit 0310641c06d
(crypto: make loaded property read-only) did what it said on the tin.
What it did was unusual, and maybe a bad idea.
Anyway, not important now.
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2024-11-04 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:47 [PATCH] crypto: purge 'loaded' property that was documented as already removed Daniel P. Berrangé
2024-10-30 18:50 ` Philippe Mathieu-Daudé
2024-11-04 8:09 ` Markus Armbruster [this message]
2024-11-05 15:07 ` Daniel P. Berrangé
2024-11-07 11:17 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j4nzagr.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.