From: Kalle Valo <kvalo@kernel.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] iwlegacy: Clear stale interrupts before resuming device
Date: Wed, 02 Oct 2024 13:42:16 +0300 [thread overview]
Message-ID: <874j5u7pmf.fsf@kernel.org> (raw)
In-Reply-To: <Zv0Y4idp6NsQ8j8g@intel.com> ("Ville Syrjälä"'s message of "Wed, 2 Oct 2024 12:56:50 +0300")
Ville Syrjälä <ville.syrjala@linux.intel.com> writes:
>> >> v2: Clear only in il_pci_resume() instead of il_enable_interrupts()
>> >> to miminize changes to runtime behaviour
>>
>> In wireless we don't include the list of changes so I'll remove this.
>
> Ack. I was wondering about that since most commits in the wireless
> code didn't seem to have one, but there were some counterexamples
> as well.
Oh, there are? It's a bit awkward that some subsystems do this and some
not, some consistency would be nice :) Not sure what we should do in
wireless..
> Maybe I'll remember for the next time, maybe not :)
No hätä. I implemented an edit command to my patchwork script just for
cases like this :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-10-02 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 12:29 [PATCH] iwlegacy: Clear stale interrupts before enabling interrupts Ville Syrjala
2024-10-01 7:03 ` Kalle Valo
2024-10-01 13:41 ` Ville Syrjälä
2024-10-01 18:18 ` Stanislaw Gruszka
2024-10-01 19:22 ` Ville Syrjälä
2024-10-01 19:45 ` Stanislaw Gruszka
2024-10-01 20:07 ` [PATCH v2] iwlegacy: Clear stale interrupts before resuming device Ville Syrjala
2024-10-02 6:49 ` Stanislaw Gruszka
2024-10-02 8:01 ` Kalle Valo
2024-10-02 8:30 ` Kalle Valo
2024-10-02 9:56 ` Ville Syrjälä
2024-10-02 10:42 ` Kalle Valo [this message]
2024-10-08 18:51 ` [v2] wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j5u7pmf.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stf_xl@wp.pl \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.