From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
intel-xe@lists.freedesktop.org,
Jonathan Cavitt <jonathan.cavitt@intel.com>,
Vinod Govindapillai <vinod.govindapillai@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340
Date: Tue, 02 Jul 2024 13:24:50 +0300 [thread overview]
Message-ID: <874j989jm5.fsf@intel.com> (raw)
In-Reply-To: <gqpfyt677ovisjdi2fzqqzjwugcvs6hxxqmkbkfckoacwpomn7@ngbrweofy2tu>
On Fri, 28 Jun 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Jun 28, 2024 at 02:36:16PM GMT, Rodrigo Vivi wrote:
>>Fair enough. Perhaps we could at least define this in i915_drv.h so we implement
>>in the compat headers and avoid the ifdef I915?
>
> yeah, I'm fine with that approach.
Based on Lucas' feedback [1] on v2, looks like we'll need the .c file
anyway. Whether that's then wrapped in intel_display_wa.h with #ifdef
I915, or i915_drv.h, up to you.
Also, for the record,
Acked-by: Jani Nikula <jani.nikula@intel.com>
on merging this via drm-xe-next.
BR,
Jani.
[1] https://lore.kernel.org/r/6hq2htqmbjjhrdad3jbgsesvteqe3g65hpznzsyk6bxj42iowq@my4rit2pa4sm
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-07-02 10:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 14:31 [PATCH 1/2] drm/xe/bmg: implement Wa_16023588340 Matthew Auld
2024-06-19 14:31 ` [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340 Matthew Auld
2024-06-20 22:20 ` Cavitt, Jonathan
2024-06-25 8:09 ` Matthew Auld
2024-06-26 15:14 ` Matthew Auld
2024-06-26 15:55 ` Rodrigo Vivi
2024-06-26 16:18 ` Matthew Auld
2024-06-26 15:53 ` Rodrigo Vivi
2024-06-26 16:17 ` Matthew Auld
2024-06-26 17:26 ` Rodrigo Vivi
2024-06-26 17:42 ` Matt Roper
2024-06-28 5:30 ` Lucas De Marchi
2024-06-28 18:36 ` Rodrigo Vivi
2024-06-28 20:23 ` Lucas De Marchi
2024-07-02 10:24 ` Jani Nikula [this message]
2024-07-02 10:18 ` Jani Nikula
2024-06-19 14:37 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/bmg: implement Wa_16023588340 Patchwork
2024-06-19 14:37 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-19 14:38 ` ✓ CI.KUnit: success " Patchwork
2024-06-19 14:50 ` ✓ CI.Build: " Patchwork
2024-06-19 14:52 ` ✗ CI.Hooks: failure " Patchwork
2024-06-19 14:53 ` ✗ CI.checksparse: warning " Patchwork
2024-06-19 15:18 ` ✓ CI.BAT: success " Patchwork
2024-06-19 20:20 ` ✓ CI.FULL: " Patchwork
2024-06-20 22:18 ` [PATCH 1/2] " Cavitt, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j989jm5.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.