Re: [PATCH 3/3] semihosting: Restrict to TCG

["Alex Bennée" <alex.bennee@linaro.org>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On Wed, May 29, 2024 at 5:56 PM Philippe Mathieu-Daudé
> <philmd@linaro.org> wrote:
>> It is pointless to build semihosting when TCG is not available.
>
> Why? I would have naively assumed that a suitable semihosting API
> could be implemented by KVM. The justification (and thus the commit
> message) needs to be different for each architecture if it's a matter
> of instruction set or insufficient KVM userspace API.

For Arm at least the HLT instruction is an external debug feature and as
such not trappable by KVM.

>
> Paolo
>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>  semihosting/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/semihosting/Kconfig b/semihosting/Kconfig
>> index eaf3a20ef5..fbe6ac87f9 100644
>> --- a/semihosting/Kconfig
>> +++ b/semihosting/Kconfig
>> @@ -1,6 +1,7 @@
>>
>>  config SEMIHOSTING
>>         bool
>> +       depends on TCG
>>
>>  config ARM_COMPATIBLE_SEMIHOSTING
>>         bool
>> --
>> 2.41.0
>>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro