From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93721C25B7A for ; Mon, 20 May 2024 12:13:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E02B10E667; Mon, 20 May 2024 12:13:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cg7+1ik8"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 923E410E666; Mon, 20 May 2024 12:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716207173; x=1747743173; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=qW/W5FGPRebv1pCe4q6o8woBVVtdPWSUQLSVLXnccD4=; b=cg7+1ik8fdBByYxeh/1QDxGVEwHsokHzGtUx40j0dapfJ4vYT23iX5CV n1ssoZ7hHjbqJYhIvMsqfsGONgJw/6DDSshcSHUB/EQcyLW0CM8EMbJdW G5/w4tmu5q5MfZDM/Unw0k09JhpcWl7DL7bPtveuABDEs0ky0aNAMrcLq rXEkjPQxDtSRTElcQ5bJAVbGzFHvIPQT3hsgtjXGH3/4Vml6gRoALvjl1 4a1VQMj1MK7xQpROKQ9k6wb3fpz6BA+m6WjH9LQdr74P146MT+kQGXL3z 52+quPew24ZpBZ8hSGbm9DRS/z604idThoIQ8fCqVutNQdl1PuMoXydio w==; X-CSE-ConnectionGUID: WD7bwgYqQTSoq7kagKZkhQ== X-CSE-MsgGUID: GZM4zyXYTJ+EPhuwV33mRQ== X-IronPort-AV: E=McAfee;i="6600,9927,11078"; a="23472405" X-IronPort-AV: E=Sophos;i="6.08,175,1712646000"; d="scan'208";a="23472405" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 05:12:53 -0700 X-CSE-ConnectionGUID: AZM/NLmdS6iuyPFBJCf7PQ== X-CSE-MsgGUID: TPKk1GaZRAaK92XHNfh/hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,175,1712646000"; d="scan'208";a="37337916" Received: from unknown (HELO localhost) ([10.245.246.99]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 05:12:51 -0700 From: Jani Nikula To: Animesh Manna , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, jouni.hogander@intel.com, arun.r.murthy@intel.com, Animesh Manna Subject: Re: [PATCH v5 6/6] drm/i915/alpm: Add debugfs for LOBF In-Reply-To: <20240520104822.1116122-7-animesh.manna@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240520104822.1116122-1-animesh.manna@intel.com> <20240520104822.1116122-7-animesh.manna@intel.com> Date: Mon, 20 May 2024 15:12:47 +0300 Message-ID: <874jasu1fk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 20 May 2024, Animesh Manna wrote: > For validation purpose add debugfs for LOBF. > > v1: Initial version. > v2: Add aux-wake/less info along with lobf status. [Jouni] > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 49 +++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_alpm.h | 2 + > .../drm/i915/display/intel_display_debugfs.c | 2 + > 3 files changed, 53 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c > index 8f4da817ef55..843ffb5fcb7a 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -360,3 +360,52 @@ void intel_alpm_configure(struct intel_dp *intel_dp, > { > lnl_alpm_configure(intel_dp, crtc_state); > } > + > +static int i915_edp_lobf_info_show(struct seq_file *m, void *data) > +{ > + struct intel_connector *connector = m->private; > + struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > + struct drm_crtc *crtc; > + struct intel_crtc_state *crtc_state; > + enum transcoder cpu_transcoder; > + u32 alpm_ctl; > + int ret; > + > + ret = drm_modeset_lock_single_interruptible(&dev_priv->drm.mode_config.connection_mutex); > + if (ret) > + return ret; > + > + crtc = connector->base.state->crtc; > + if (connector->base.status != connector_status_connected || !crtc) { > + ret = -ENODEV; > + goto out; > + } > + > + crtc_state = to_intel_crtc_state(crtc->state); > + cpu_transcoder = crtc_state->cpu_transcoder; > + alpm_ctl = intel_de_read(dev_priv, ALPM_CTL(dev_priv, cpu_transcoder)); > + seq_printf(m, "LOBF status: %s\n", str_enabled_disabled(alpm_ctl & ALPM_CTL_LOBF_ENABLE)); > + seq_printf(m, "Aux-wake alpm status: %s\n", > + str_enabled_disabled(!(alpm_ctl & ALPM_CTL_ALPM_AUX_LESS_ENABLE))); > + seq_printf(m, "Aux-less alpm status: %s\n", > + str_enabled_disabled(alpm_ctl & ALPM_CTL_ALPM_AUX_LESS_ENABLE)); > +out: > + drm_modeset_unlock(&dev_priv->drm.mode_config.connection_mutex); > + > + return ret; > +} > + > +DEFINE_SHOW_ATTRIBUTE(i915_edp_lobf_info); > + > +void intel_alpm_lobf_debugfs_add(struct intel_connector *connector) This file is about alpm, and might add more alpm related debugfs files later. There's no need to encode lobf in the name here. > +{ > + struct drm_i915_private *i915 = to_i915(connector->base.dev); > + struct dentry *root = connector->base.debugfs_entry; > + > + if (DISPLAY_VER(i915) < 20 || > + connector->base.connector_type != DRM_MODE_CONNECTOR_eDP) > + return; > + > + debugfs_create_file("i915_edp_lobf_info", 0444, root, Why does the filename need to include edp? The connector debugfs files for psr don't include that either. > + connector, &i915_edp_lobf_info_fops); > +} > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h > index fd9be8aa876c..0dab2068164a 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > @@ -11,6 +11,7 @@ > struct intel_dp; > struct intel_crtc_state; > struct drm_connector_state; > +struct intel_connector; > > void intel_alpm_get_capability(struct intel_dp *intel_dp); > bool intel_alpm_compute_params(struct intel_dp *intel_dp, > @@ -20,4 +21,5 @@ void intel_alpm_compute_lobf_config(struct intel_dp *intel_dp, > struct drm_connector_state *conn_state); > void intel_alpm_configure(struct intel_dp *intel_dp, > const struct intel_crtc_state *crtc_state); > +void intel_alpm_lobf_debugfs_add(struct intel_connector *connector); > #endif > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index 35f9f86ef70f..86d9900c40af 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -13,6 +13,7 @@ > #include "i915_debugfs.h" > #include "i915_irq.h" > #include "i915_reg.h" > +#include "intel_alpm.h" > #include "intel_crtc.h" > #include "intel_de.h" > #include "intel_crtc_state_dump.h" > @@ -1515,6 +1516,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector) > intel_drrs_connector_debugfs_add(connector); > intel_pps_connector_debugfs_add(connector); > intel_psr_connector_debugfs_add(connector); > + intel_alpm_lobf_debugfs_add(connector); All the others are intel_foo_connector_debugfs_add(). So should this. > > if (connector_type == DRM_MODE_CONNECTOR_DisplayPort || > connector_type == DRM_MODE_CONNECTOR_HDMIA || -- Jani Nikula, Intel