All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org,  kkostiuk@redhat.com,  michael.roth@amd.com
Subject: Re: [PATCH 2/3] qga: Shorten several error messages
Date: Tue, 14 May 2024 13:02:59 +0200	[thread overview]
Message-ID: <874jb03bbw.fsf@pond.sub.org> (raw)
In-Reply-To: <20240514105829.729342-3-armbru@redhat.com> (Markus Armbruster's message of "Tue, 14 May 2024 12:58:27 +0200")

Markus Armbruster <armbru@redhat.com> writes:

> Some, but not all error messages are of the form
>
>     Guest agent command failed, error was '<actual error message>'
>
> For instance, command guest-exec can fail with an error message like
>
>     Guest agent command failed, error was 'Failed to execute child process “/bin/invalid-cmd42” (No such file or directory)'
>
> Shorten this to just just the actual error message.  The guest-exec
> example becomes
>
>     Failed to execute child process “/bin/invalid-cmd42” (No such file or directory)
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

[...]

To be squashed into the patch:

diff --git a/qga/commands.c b/qga/commands.c
index 27b16313ea..5a5fad31f8 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -15,7 +15,6 @@
 #include "guest-agent-core.h"
 #include "qga-qapi-commands.h"
 #include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
 #include "qemu/base64.h"
 #include "qemu/cutils.h"
 #include "commands-common.h"



  reply	other threads:[~2024-05-14 11:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 10:58 [PATCH 0/3] error: Eliminate QERR_QGA_COMMAND_FAILED Markus Armbruster
2024-05-14 10:58 ` [PATCH 1/3] qga-win32: Improve guest-set-user-password, guest-file-open errors Markus Armbruster
2024-05-14 13:16   ` Philippe Mathieu-Daudé
2024-05-14 17:38   ` Konstantin Kostiuk
2024-05-14 10:58 ` [PATCH 2/3] qga: Shorten several error messages Markus Armbruster
2024-05-14 11:02   ` Markus Armbruster [this message]
2024-05-14 13:17     ` Philippe Mathieu-Daudé
2024-05-14 17:39   ` Konstantin Kostiuk
2024-05-14 10:58 ` [PATCH 3/3] qerror: QERR_QGA_COMMAND_FAILED is no longer used, drop Markus Armbruster
2024-05-14 13:17   ` Philippe Mathieu-Daudé
2024-05-14 17:39   ` Konstantin Kostiuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jb03bbw.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=kkostiuk@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.