From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
Cc: Nicolas Escande <nico.escande@gmail.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: drop failed transmitted frames from metric calculation.
Date: Tue, 23 Apr 2024 12:42:48 +0300 [thread overview]
Message-ID: <874jbsv2hz.fsf@kernel.org> (raw)
In-Reply-To: <f4c65f7e-ccc7-4a0b-a6e8-df56d5c19d7f@quicinc.com> (Karthikeyan Kathirvel's message of "Mon, 22 Apr 2024 22:27:45 +0530")
Karthikeyan Kathirvel <quic_kathirve@quicinc.com> writes:
> On 4/22/2024 1:35 PM, Nicolas Escande wrote:
>> On Fri Apr 19, 2024 at 7:03 PM CEST, Karthikeyan Kathirvel wrote:
>>
>>> + case HAL_WBM_TQM_REL_REASON_CMD_REMOVE_MPDU:
>>> + case HAL_WBM_TQM_REL_REASON_DROP_THRESHOLD:
>>> + case HAL_WBM_TQM_REL_REASON_CMD_REMOVE_AGED_FRAMES:
>>> + /* The failure status is due to internal firmware tx failure
>>> + * hence drop the frame do not update the status of frame to
>>> + * the upper layer
>>> + */
>>> + dev_kfree_skb_any(msdu);
>>
>> Shouldn't this be ieee80211_free_txskb ? I'm not clear when to use
>> which.
>
> Yes, there is an internal patch is in pipeline, that will take care of
> addressing all dev_kfree_skb_any() to ieee80211_free_txskb() in
> ath12k_dp_tx_complete_msdu(), this patch doesn't take care of that.
Let's not add new bugs knowingly. Please fix this patch to use
ieee80211_free_txskb(), that is much more reliable than waiting for some
other patch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-23 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 17:03 [PATCH] wifi: ath12k: drop failed transmitted frames from metric calculation Karthikeyan Kathirvel
2024-04-19 18:08 ` Jeff Johnson
2024-04-22 8:05 ` Nicolas Escande
2024-04-22 16:57 ` Karthikeyan Kathirvel
2024-04-23 9:42 ` Kalle Valo [this message]
2024-04-29 11:52 ` Karthikeyan Kathirvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jbsv2hz.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico.escande@gmail.com \
--cc=quic_kathirve@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.