All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lee Jones <lee@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>
Cc: deller@gmx.de, kherbst@redhat.com, lyude@redhat.com,
	dakr@redhat.com, daniel@ffwll.ch, airlied@gmail.com,
	gregkh@linuxfoundation.org,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h>
Date: Mon, 26 Feb 2024 13:42:53 +0200	[thread overview]
Message-ID: <874jdvo3ia.fsf@intel.com> (raw)
In-Reply-To: <20240223105652.GT10170@google.com>

On Fri, 23 Feb 2024, Lee Jones <lee@kernel.org> wrote:
> On Wed, 21 Feb 2024, Thomas Zimmermann wrote:
>
>> cc'ing backlight maintainers
>
> I cannot review/accept patches like this.
>
> Please submit a [RESEND].

I bounced the original [1] to you. Please consider acking to merge the
one-line #include addition via fbdev so we don't have to respin the
series for no good reason.

BR,
Jani.


[1] https://lore.kernel.org/r/20240219093941.3684-2-tzimmermann@suse.de

>
>> Am 19.02.24 um 10:37 schrieb Thomas Zimmermann:
>> > Resolves the proxy include via <linux/fb.h>, which does not require the
>> > backlight header.
>> > 
>> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> > ---
>> >   drivers/video/backlight/corgi_lcd.c | 1 +
>> >   1 file changed, 1 insertion(+)
>> > 
>> > diff --git a/drivers/video/backlight/corgi_lcd.c b/drivers/video/backlight/corgi_lcd.c
>> > index 0a57033ae31d1..dd765098ad989 100644
>> > --- a/drivers/video/backlight/corgi_lcd.c
>> > +++ b/drivers/video/backlight/corgi_lcd.c
>> > @@ -11,6 +11,7 @@
>> >    *	by Eric Miao <eric.miao@marvell.com>
>> >    */
>> > +#include <linux/backlight.h>
>> >   #include <linux/module.h>
>> >   #include <linux/kernel.h>
>> >   #include <linux/init.h>
>> 
>> -- 
>> --
>> Thomas Zimmermann
>> Graphics Driver Developer
>> SUSE Software Solutions Germany GmbH
>> Frankenstrasse 146, 90461 Nuernberg, Germany
>> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
>> HRB 36809 (AG Nuernberg)
>> 

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-02-26 11:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19  9:37 [PATCH v3 0/9] fbdev: Clean up include dependencies in header Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 1/9] backlight/corgi-lcd: Include <linux/backlight.h> Thomas Zimmermann
2024-02-21 10:29   ` Thomas Zimmermann
2024-02-23 10:56     ` Lee Jones
2024-02-26 11:42       ` Jani Nikula [this message]
2024-02-26 12:33         ` Lee Jones
2024-02-26 12:48           ` Thomas Zimmermann
2024-02-26 12:52             ` Lee Jones
2024-02-19  9:37 ` [PATCH v3 2/9] drm/nouveau: " Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 3/9] staging/fbtft: " Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 4/9] fbdev: Do not include <linux/backlight.h> in header Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 5/9] fbdev: Do not include <linux/fs.h> " Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 6/9] fbdev: Do not include <linux/notifier.h> " Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 7/9] fbdev: Do not include <linux/slab.h> " Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 8/9] fbdev: Clean up forward declarations in header file Thomas Zimmermann
2024-02-19  9:37 ` [PATCH v3 9/9] fbdev: Clean up include statements " Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jdvo3ia.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=dakr@redhat.com \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jingoohan1@gmail.com \
    --cc=kherbst@redhat.com \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.