Re: [PATCH 0/1 v2] Only activate drive once during system resume

[Phillip Susi <phill@thesusis.net>]

Niklas Cassel <cassel@kernel.org> writes:

> 1) Your patches are missing a Signed-off-by tag.
> Without this, we can't accept your changes, see:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Yea, they aren't ready to merge yet, so I didn't add the tag.  I suppose
I could have put RFC in the subject.

> 4) Please use git format-patch and git send-email.

I did.

> Looking at
> https://lore.kernel.org/linux-ide/
> as well as my local inbox,
> the threading seems very wrong.
>
> There is a [PATCH 0/1], and then a patch "[PATCH 0/1 v2]"
> that replies to the [PATCH 0/1].

Yes; I sent the second version as a reply to the first.  Isn't that the
usual way of doing it?  So that you can see the whole thread going back
through the older versions?

> Additionally, there is also a [PATCH 1/4] that also replies
> to the [PATCH 0/1].

That's a few replies down from [PATCH 0/1].  There was some discussion
first, then I sent that patch series as a reply to that discussion.

> It is just impossible to follow.

The flow makes perfect sense to me.

> For more info, see:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#explicit-in-reply-to-headers

I see.  I guess I'll avoid that in the future then.