From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C252C4167B for ; Tue, 5 Dec 2023 12:51:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F12FE10E51C; Tue, 5 Dec 2023 12:51:03 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59CA810E51C for ; Tue, 5 Dec 2023 12:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701780662; x=1733316662; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=r3YHsIMffIUb366nVcSWpoGB/SRr8aK/f7x2rfxg6k8=; b=KXXAq4RHsbUYz671efqmgZSjXj5jRFJKmQTh6LByQgWtKZCYGiBmw6gJ W/ymFlfZINf//+Wmd5vPCudrd1fAtvqPeAUhvYWA7Ed4QLPw/9/o/5I3g bhOXAPAR6aoOtdeUY3Nob92k5hTzV0nXttc92lp/609w5RNzAMMynhdIY dxf2dQy6r6ewLg6e5gabzcBdNVejpeDhJLPnxZapgQ2/tpfHf9GDFmhlA IxkhkhE65TNclg7HYhH4lscuQmMvQFcBPFLbsYjc50uAhMXIYdKs2Khp6 krglTPcgw6A9RojLCIjvUjYDEPzA/wYhfKxfUIeOjqBGSL1QpDmXa9md2 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="458210415" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="458210415" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 04:51:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="18955879" Received: from pesir-mobl.ger.corp.intel.com (HELO localhost) ([10.252.61.103]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 04:51:01 -0800 From: Jani Nikula To: "Shankar, Uma" , Ville =?utf-8?B?U3lyasOkbMOk?= In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231201134141.1569265-1-jani.nikula@intel.com> <87wmtu2str.fsf@intel.com> <87a5qp3oe1.fsf@intel.com> Date: Tue, 05 Dec 2023 14:50:57 +0200 Message-ID: <874jgw3j9q.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH] drm/i915/edp: don't write to DP_LINK_BW_SET when using rate select X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 05 Dec 2023, "Shankar, Uma" wrote: >> Yeah, writing 0 is done with an intention to disable it but that=E2=80= =99s not the way to >> have this option disabled. Infact there is no reason to write to it for = DP1.4+ if sink >> is compliant. > > The change looks ok and aligns with spec, its > Reviewed-by: Uma Shankar Ville, any further objections or concerns? Okay to merge? BR, Jani. --=20 Jani Nikula, Intel