From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D106DC5ACB3 for ; Tue, 21 Nov 2023 04:13:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88CFD10E035; Tue, 21 Nov 2023 04:13:00 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6452910E035 for ; Tue, 21 Nov 2023 04:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700539979; x=1732075979; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=HzXabnpkaKnpIbYxQP1IYzKELsJoOjQgBJUPvptQ7SI=; b=dgLE/jMUxJXbjNfeHkrrurrlHxUD4pOoStly61JF0lhzqzVUvDLZ87Ko OkB6K8uBsnOTuPjD458nuZ4KJo1cnzcBd7oIZVfVgePier7QF/+LZUokH A57GD3zFc8kLPIz2tWksce2bkqmIgFExB5GsAJHXJHrl0ZA3l+yVmRybR 1BFihZMTClQtRe5i2WOp3bnJTTWsfRDMUEMBLwQ0FYT2feqvqqto1a8Ek Q9wLxubZFg0eNrdpJhYzlXsId3f+J96c8RtZRXF98Uc3z2j1hV7J1YBCS 94csAYPb9gQozUVf84HSwPzjvu93LLJxWFaKihGMxZ01mQPbJP5tuu9X9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="395690027" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="395690027" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 20:12:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="7774016" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.102.163]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 20:12:59 -0800 Date: Mon, 20 Nov 2023 20:12:58 -0800 Message-ID: <874jhf7nhx.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sujaritha Sundaresan In-Reply-To: <20231116143043.908412-2-sujaritha.sundaresan@intel.com> References: <20231116143043.908412-1-sujaritha.sundaresan@intel.com> <20231116143043.908412-2-sujaritha.sundaresan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [RFC 1/4] drm/xe: Moving and renaming existing frequency sysfs attributes X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org, vivi.rodrigo@intel.com Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 16 Nov 2023 06:30:40 -0800, Sujaritha Sundaresan wrote: > Hi Suja, > Creating a new freq directory to move frequency sysfs attributes. > Additonally, renaming the frequency sysfs to align with devfreq > requirements. > > /device/tile/gt/freq > |- act_freq > |- cur_freq > |- max_freq > |- min_freq > |- rp0_freq > |- rpn_freq > |- rpe_freq So apparently this was not tested before being submitted? Otherwise I don't see how you could have missed the kernel crash and segmentation fault this causes? Any case, I have basically submitted a revert patch for this so that you can fix it and resubmit the patch: https://patchwork.freedesktop.org/patch/568348/?series=126683&rev=1 Thanks. -- Ashutosh