From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8076C2BB3F for ; Mon, 20 Nov 2023 20:02:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5AT2-0008H4-6t; Mon, 20 Nov 2023 15:02:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5ASw-0008GZ-Me for qemu-devel@nongnu.org; Mon, 20 Nov 2023 15:01:55 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5ASt-0008Uk-O2 for qemu-devel@nongnu.org; Mon, 20 Nov 2023 15:01:54 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 877F61F895; Mon, 20 Nov 2023 20:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700510510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6kjBij3f64WkHlnqHM6BW8lqDBCEzvfFS0DLGoFduPo=; b=SxngUewpaT1U8aiFSFvlkcL+obhYcEHyOZgjVMCTQjxWMUjOmnvZgmYjGhtF/IlDKiFCQz PvTuE2d/KMAPYE5r8QKNVT6E8y7Z7HZK7xoB3fEo2c5JPGekf1bZCUA50AF4dGv4+MpV5l 0h4qErEKA07g+f1CeF0Dbdm5zKcoazw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700510510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6kjBij3f64WkHlnqHM6BW8lqDBCEzvfFS0DLGoFduPo=; b=VXV/axyUTk1imZVvnz2+ZebliNehnEFMJ78NOIuHbefz2BgvayMzTkmPIz1pm/Afw6q6qC hfFwDN+b6hMsIyCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 204EF134AD; Mon, 20 Nov 2023 20:01:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KUFFNy27W2WAWgAAMHmgww (envelope-from ); Mon, 20 Nov 2023 20:01:49 +0000 From: Fabiano Rosas To: Steven Sistare , qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Paolo Bonzini , Thomas Huth , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Leonardo Bras Subject: Re: [PATCH V5 01/12] cpus: refactor vm_stop In-Reply-To: <250d0338-d29d-4cd0-8e33-0520fd1fb354@oracle.com> References: <1699900440-207345-1-git-send-email-steven.sistare@oracle.com> <1699900440-207345-2-git-send-email-steven.sistare@oracle.com> <87leas5zlo.fsf@suse.de> <250d0338-d29d-4cd0-8e33-0520fd1fb354@oracle.com> Date: Mon, 20 Nov 2023 17:01:47 -0300 Message-ID: <874jhg5h3o.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-1.31 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-0.01)[50.21%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Steven Sistare writes: > On 11/20/2023 8:22 AM, Fabiano Rosas wrote: >> Steve Sistare writes: >>> Refactor the vm_stop functions into one common subroutine do_vm_stop called >>> with options. No functional change. >>> >>> Signed-off-by: Steve Sistare >>> --- >>> system/cpus.c | 44 +++++++++++++++++--------------------------- >>> 1 file changed, 17 insertions(+), 27 deletions(-) >>> >>> diff --git a/system/cpus.c b/system/cpus.c >>> index 0848e0d..f72c4be 100644 >>> --- a/system/cpus.c >>> +++ b/system/cpus.c >>> @@ -252,10 +252,21 @@ void cpu_interrupt(CPUState *cpu, int mask) >>> } >>> } >>> >>> -static int do_vm_stop(RunState state, bool send_stop) >>> +static int do_vm_stop(RunState state, bool send_stop, bool force) >>> { >>> int ret = 0; >>> >>> + if (qemu_in_vcpu_thread()) { >>> + qemu_system_vmstop_request_prepare(); >>> + qemu_system_vmstop_request(state); >>> + /* >>> + * FIXME: should not return to device code in case >>> + * vm_stop() has been requested. >>> + */ >>> + cpu_stop_current(); >>> + return 0; >>> + } >> >> At vm_stop_force_state(), this block used to be under >> runstate_is_running(), but now it runs unconditionally. > > vm_stop_force_state callers should never be called in a vcpu thread, so this block > is never executed for them. I could assert that. > >> At vm_shutdown(), this block was not executed at all, but now it is. > > vm_shutdown should never be called from a vcpu thread. > I could assert that. Yes, this is an assumption that will get lost to time unless we document it or have code to enforce.