All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: David Lin <yu-hao.lin@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"briannorris@chromium.org" <briannorris@chromium.org>,
	Sharvari Harisangam <sharvari.harisangam@nxp.com>,
	Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: Re: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.
Date: Mon, 23 Oct 2023 12:07:49 +0300	[thread overview]
Message-ID: <874jih1zbu.fsf@kernel.org> (raw)
In-Reply-To: <PA4PR04MB9638847CEC6D16AE53B3875FD1D8A@PA4PR04MB9638.eurprd04.prod.outlook.com> (David Lin's message of "Mon, 23 Oct 2023 02:11:02 +0000")

David Lin <yu-hao.lin@nxp.com> writes:

>> From: Francesco Dolcini <francesco@dolcini.it>
>> Sent: Friday, October 20, 2023 11:25 PM
>> To: David Lin <yu-hao.lin@nxp.com>
>> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
>> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Sharvari
>> Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
>> <tsung-hsien.hsieh@nxp.com>
>> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
>> mlme.
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
>> > Patch v6:
>> > Correct mailing sequence.
>>
>> You are still doing something wrong sending the patches over email, the
>> various emails are not threaded as expected, git-send-email should do
>> everything for you.
>>
>> No need to re-send now IMO, but please figure out what's wrong for the next
>> time.
>>
>> To give you an idea here [1] you see this email alone.
>>
>> This [2] and this [3] are examples of a properly sent patch series (just random
>> series from your NXP colleagues).
>>
>> You have also a winmail.dat file attached to every email in this series, not sure
>> what it is, but I would try to not send it.
>>
>
> Yes. I can send them as a single e-mail. However, I find other member
> would send multiple patches as separate e-mails with a cover letter. I
> think it would be easier for review.

We are not asking to send the patches as single email. We are asking to
run git send-email only _once_ per patchset to make sure threading is
correct (ie. References and In-Reply-to headers are set). For example,
you can do it like this:

$ git format-patch --base=auto --cover-letter -o outgoing/ main
outgoing/0000-cover-letter.patch
outgoing/0001-First-Commit.patch
outgoing/...

$ git send-email [...] outgoing/

More info:

https://wireless.wiki.kernel.org/en/developers/documentation/git-guide

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-10-23  9:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20  3:48 [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme David Lin
2023-10-20 15:24 ` Francesco Dolcini
2023-10-23  2:11   ` [EXT] " David Lin
2023-10-23  9:07     ` Kalle Valo [this message]
2023-10-24  7:27       ` David Lin
2023-10-24  0:02   ` Jeff Johnson
2023-10-24  6:07     ` [EXT] " David Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jih1zbu.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=briannorris@chromium.org \
    --cc=francesco@dolcini.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sharvari.harisangam@nxp.com \
    --cc=tsung-hsien.hsieh@nxp.com \
    --cc=yu-hao.lin@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.