From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE7AFE743F2 for ; Fri, 29 Sep 2023 08:02:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qm8S3-0005P4-NB; Fri, 29 Sep 2023 04:02:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm8S2-0005Oh-Fa for qemu-devel@nongnu.org; Fri, 29 Sep 2023 04:02:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm8S0-0002GK-JE for qemu-devel@nongnu.org; Fri, 29 Sep 2023 04:02:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695974535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ATImA/uraUj/V6ZNE6zDqKhplxmrrrTKP936D1dw1gQ=; b=iJvhPxFceOMGXMUdrS1YqKOQzI/QW1UDASTNwfdr8wN903OJNUsupMzemWz5qOtGbTMTgZ yNalvQNuAMCPn6i7FSlBuFXaDs0TvfnD9AgvQctKUIgdskPnabcZjIqQjanFpVLS5Swrfm 7Rxnr+P50wV3xB6ArP7Oy/FGnHUKh8Y= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-671-pwNU_5OEOi2NR3gzDPu_MQ-1; Fri, 29 Sep 2023 04:02:13 -0400 X-MC-Unique: pwNU_5OEOi2NR3gzDPu_MQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8344B29AA3B9; Fri, 29 Sep 2023 08:02:12 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 598D514171B6; Fri, 29 Sep 2023 08:02:12 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4D8FB21E6904; Fri, 29 Sep 2023 10:02:11 +0200 (CEST) From: Markus Armbruster To: Ani Sinha Cc: "Michael S. Tsirkin" , Igor Mammedov , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Philippe Mathieu-Daude , qemu-devel@nongnu.org Subject: Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local References: <20230922124203.127110-1-anisinha@redhat.com> <87msx5jztb.fsf@pond.sub.org> <5A625074-8DE2-4B58-8B7D-C7FA578F6688@redhat.com> <87r0mhik1n.fsf@pond.sub.org> Date: Fri, 29 Sep 2023 10:02:11 +0200 In-Reply-To: (Ani Sinha's message of "Fri, 29 Sep 2023 11:45:13 +0530") Message-ID: <874jjdflvg.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Ani Sinha writes: >> On 29-Sep-2023, at 11:43 AM, Markus Armbruster wrote: >> >> Ani Sinha writes: >> >>>> On 29-Sep-2023, at 11:17 AM, Markus Armbruster wrote: >>>> >>>> Ani Sinha writes: >>>> >>>>> Code changes in acpi that addresses all compiler complaints coming from enabling >>>>> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >>>>> other local variables or parameters. These makes the code confusing and/or adds >>>>> bugs that are difficult to catch. >>>>> >>>>> The code is tested to build with and without the flag turned on. >>>>> >>>>> CC: Markus Armbruster >>>>> CC: Philippe Mathieu-Daude >>>>> CC: mst@redhat.com >>>>> CC: imammedo@redhat.com >>>>> Message-Id: <87r0mqlf9x.fsf@pond.sub.org> >>>> >>>> This is my "Help wanted for enabling -Wshadow=local" post. >>> >>> Yes indeed. I wanted to refer to that thread for context in the commit log. >> >> I appreciate your diligence. We just don't have an established tag >> convention for "see also" references to e-mail. I could append >> >> See also >> >> Subject: Help wanted for enabling -Wshadow=local >> Message-Id: <87r0mqlf9x.fsf@pond.sub.org> >> https://lore.kernel.org/qemu-devel/87r0mqlf9x.fsf@pond.sub.org >> >> to your first paragraph. Want me to? > > Sure, if that is ok. Done!