From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] target/i386/seg_helper: remove shadowed variable
Date: Tue, 26 Sep 2023 16:53:45 +0200 [thread overview]
Message-ID: <874jjhnfye.fsf@pond.sub.org> (raw)
In-Reply-To: <CABgObfbt5ZsbQy2D9wb9Ns+rc_r3+6-Y_oG3O8Pe0+T3XtxBzg@mail.gmail.com> (Paolo Bonzini's message of "Tue, 26 Sep 2023 16:33:55 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il mar 26 set 2023, 15:16 Markus Armbruster <armbru@redhat.com> ha scritto:
>
>> I still get these:
>>
>> ../target/i386/tcg/seg_helper.c: In function ‘switch_tss_ra’:
>> ../target/i386/tcg/seg_helper.c:344:22: warning: declaration of ‘ptr’
>> shadows a previous local [-Wshadow=compatible-local]
>> 344 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:245:18: note: shadowed declaration is here
>> 245 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:345:18: warning: declaration of ‘e2’
>> shadows a parameter [-Wshadow=compatible-local]
>> 345 | uint32_t e2;
>> | ^~
>> ../target/i386/tcg/seg_helper.c:235:48: note: shadowed declaration is here
>> 235 | uint32_t e1, uint32_t e2, int source,
>> | ~~~~~~~~~^~
>> ../target/i386/tcg/seg_helper.c:402:22: warning: declaration of ‘ptr’
>> shadows a previous local [-Wshadow=compatible-local]
>> 402 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:245:18: note: shadowed declaration is here
>> 245 | target_ulong ptr;
>> | ^~~
>> ../target/i386/tcg/seg_helper.c:403:18: warning: declaration of ‘e2’
>> shadows a parameter [-Wshadow=compatible-local]
>> 403 | uint32_t e2;
>> | ^~
>> ../target/i386/tcg/seg_helper.c:235:48: note: shadowed declaration is here
>> 235 | uint32_t e1, uint32_t e2, int source,
>> | ~~~~~~~~~^~
>>
>
> There's another seg_helper patch. 8)
Ah, missed it, because it doesn't have "shadow" in the subject. Added
to my collection now. Thanks!
prev parent reply other threads:[~2023-09-26 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 14:49 [PATCH] target/i386/seg_helper: remove shadowed variable Paolo Bonzini
2023-09-26 13:16 ` Markus Armbruster
2023-09-26 14:33 ` Paolo Bonzini
2023-09-26 14:53 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jjhnfye.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.