From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C64E1C001DE for ; Mon, 24 Jul 2023 09:25:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNroS-0005QC-PU; Mon, 24 Jul 2023 05:25:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNroP-0005Pu-8K for qemu-devel@nongnu.org; Mon, 24 Jul 2023 05:25:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNroN-00008f-PC for qemu-devel@nongnu.org; Mon, 24 Jul 2023 05:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690190703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vp7nYK+x5B8iFLwVsHO8+0byOR9o/IQ2qeOrnJYXbyA=; b=BG92YKTeaBx7+jqX182u8VFQJVKP2t/m546MyN38AlzhY4+l89y9mYvSVQAYZ5Kg1d3d2k yxKHGk4utAblUPOkPJ7w1a7TtsP4NKg565aw6CnxnGVcw3QVe9OB3D7oYH7nXbkEbwkOuA az8lRfpX+PovC0ZJaT/j9iS+5Q/LwAE= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-FUV2QE-9MJqm4QKsOPCHig-1; Mon, 24 Jul 2023 05:24:59 -0400 X-MC-Unique: FUV2QE-9MJqm4QKsOPCHig-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D7B7280AA22; Mon, 24 Jul 2023 09:24:59 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 590631121315; Mon, 24 Jul 2023 09:24:59 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 37FE021E64D0; Mon, 24 Jul 2023 11:24:58 +0200 (CEST) From: Markus Armbruster To: ~hyman Cc: qemu-devel@nongnu.org, ~hyman , Juan Quintela , Peter Xu , Leonardo Bras , Eric Blake , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: Re: [PATCH QEMU v9 4/9] migration: Introduce dirty-limit capability References: <168987012554.14797.8679831725383645706-4@git.sr.ht> Date: Mon, 24 Jul 2023 11:24:58 +0200 In-Reply-To: <168987012554.14797.8679831725383645706-4@git.sr.ht> (hyman@git.sr.ht's message of "Wed, 07 Jun 2023 23:30:50 +0800") Message-ID: <874jltr79x.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org ~hyman writes: > From: Hyman Huang(=E9=BB=84=E5=8B=87) > > Introduce migration dirty-limit capability, which can > be turned on before live migration and limit dirty > page rate durty live migration. > > Introduce migrate_dirty_limit function to help check > if dirty-limit capability enabled during live migration. > > Meanwhile, refactor vcpu_dirty_rate_stat_collect > so that period can be configured instead of hardcoded. > > dirty-limit capability is kind of like auto-converge > but using dirty limit instead of traditional cpu-throttle > to throttle guest down. To enable this feature, turn on > the dirty-limit capability before live migration using > migrate-set-capabilities, and set the parameters > "x-vcpu-dirty-limit-period", "vcpu-dirty-limit" suitably > to speed up convergence. > > Signed-off-by: Hyman Huang(=E9=BB=84=E5=8B=87) > Acked-by: Peter Xu > Reviewed-by: Markus Armbruster > Reviewed-by: Juan Quintela Looks good now, thanks!