From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Daniel Xu <dxu@dxuuu.xyz>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
fw@strlen.de, daniel@iogearbox.net
Cc: dsahern@kernel.org
Subject: Re: [PATCH bpf-next 0/7] Support defragmenting IPv(4|6) packets in BPF
Date: Tue, 27 Jun 2023 16:25:13 +0200 [thread overview]
Message-ID: <874jmthtiu.fsf@toke.dk> (raw)
In-Reply-To: <cover.1687819413.git.dxu@dxuuu.xyz>
> The basic idea is we bump a refcnt on the netfilter defrag module and
> then run the bpf prog after the defrag module runs. This allows bpf
> progs to transparently see full, reassembled packets. The nice thing
> about this is that progs don't have to carry around logic to detect
> fragments.
One high-level comment after glancing through the series: Instead of
allocating a flag specifically for the defrag module, why not support
loading (and holding) arbitrary netfilter modules in the UAPI? If we
need to allocate a new flag every time someone wants to use a netfilter
module along with BPF we'll run out of flags pretty quickly :)
-Toke
next prev parent reply other threads:[~2023-06-27 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 23:02 [PATCH bpf-next 0/7] Support defragmenting IPv(4|6) packets in BPF Daniel Xu
2023-06-26 23:02 ` [PATCH bpf-next 1/7] tools: libbpf: add netfilter link attach helper Daniel Xu
2023-06-27 0:11 ` Andrii Nakryiko
2023-06-26 23:02 ` [PATCH bpf-next 2/7] selftests/bpf: Add bpf_program__attach_netfilter helper test Daniel Xu
2023-06-26 23:02 ` [PATCH bpf-next 3/7] netfilter: defrag: Add glue hooks for enabling/disabling defrag Daniel Xu
2023-06-27 11:04 ` Florian Westphal
2023-06-26 23:02 ` [PATCH bpf-next 4/7] netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link Daniel Xu
2023-06-27 11:12 ` Florian Westphal
2023-06-27 15:35 ` Daniel Xu
2023-06-26 23:02 ` [PATCH bpf-next 5/7] bpf: selftests: Support not connecting client socket Daniel Xu
2023-06-26 23:02 ` [PATCH bpf-next 6/7] bpf: selftests: Support custom type and proto for client sockets Daniel Xu
2023-06-26 23:02 ` [PATCH bpf-next 7/7] bpf: selftests: Add defrag selftests Daniel Xu
2023-06-27 10:48 ` [PATCH bpf-next 0/7] Support defragmenting IPv(4|6) packets in BPF Florian Westphal
2023-06-27 14:18 ` Daniel Xu
2023-06-27 14:25 ` Toke Høiland-Jørgensen [this message]
2023-06-27 14:51 ` Daniel Xu
2023-06-27 15:44 ` Florian Westphal
2023-06-29 12:16 ` Toke Høiland-Jørgensen
2023-06-29 13:21 ` Florian Westphal
2023-06-29 14:35 ` Toke Høiland-Jørgensen
2023-06-29 14:53 ` Florian Westphal
2023-06-29 17:59 ` Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jmthtiu.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.