From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: thuth@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 02/10] configure: rename --enable-pypi to --enable-download, control subprojects too
Date: Mon, 05 Jun 2023 11:28:22 +0100 [thread overview]
Message-ID: <874jnm19v8.fsf@linaro.org> (raw)
In-Reply-To: <20230605095223.107653-3-pbonzini@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> The behavior of --{enable,disable}-pypi is similar to that of
> -Dwrapmode={default,nodownload} respectively. In particular,
> in both cases a feature needs to be explicitly enabled for the
> dependency to be downloaded.
>
> So, use a single option to control both cases. Now, --enable-slirp
> will trigger cloning and building of libslirp if the .pc file
> is not found on the machine.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-06-05 10:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 9:52 [PATCH v2 00/10] meson: replace submodules with wrap files Paolo Bonzini
2023-06-05 9:52 ` [PATCH 01/10] configure: remove --with-git= option Paolo Bonzini
2023-06-05 10:27 ` Alex Bennée
2023-06-05 11:17 ` Thomas Huth
2023-06-05 9:52 ` [PATCH 02/10] configure: rename --enable-pypi to --enable-download, control subprojects too Paolo Bonzini
2023-06-05 10:28 ` Alex Bennée [this message]
2023-06-05 9:52 ` [PATCH 03/10] git-submodule: allow partial update of .git-submodule-status Paolo Bonzini
2023-06-05 10:55 ` Alex Bennée
2023-06-05 9:52 ` [PATCH 04/10] build: log submodule update from git-submodule.sh Paolo Bonzini
2023-06-05 10:56 ` Alex Bennée
2023-06-05 11:11 ` Alex Bennée
2023-06-05 9:52 ` [PATCH 05/10] meson: subprojects: replace submodules with wrap files Paolo Bonzini
2023-06-06 9:54 ` Daniel P. Berrangé
2023-06-05 9:52 ` [PATCH 06/10] configure: move SLOF submodule handling to pc-bios/s390-ccw Paolo Bonzini
2023-06-06 9:56 ` Daniel P. Berrangé
2023-06-06 10:07 ` Thomas Huth
2023-06-05 9:52 ` [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader Paolo Bonzini
2023-06-06 9:56 ` Daniel P. Berrangé
2023-06-06 10:08 ` Thomas Huth
2023-06-16 15:20 ` Nina Schoetterl-Glausch
2023-06-22 8:42 ` Thomas Huth
2023-06-22 9:47 ` Paolo Bonzini
2023-06-05 9:52 ` [PATCH 08/10] meson: subprojects: replace berkeley-{soft, test}float-3 with wraps Paolo Bonzini
2023-06-06 9:58 ` [PATCH 08/10] meson: subprojects: replace berkeley-{soft,test}float-3 " Daniel P. Berrangé
2023-06-05 9:52 ` [PATCH 09/10] build: remove git submodule handling from main makefile Paolo Bonzini
2023-06-06 9:59 ` Daniel P. Berrangé
2023-06-05 9:52 ` [PATCH 10/10] configure: remove --with-git-submodules= Paolo Bonzini
2023-06-06 10:00 ` Daniel P. Berrangé
2023-06-07 7:41 ` [PATCH v2 00/10] meson: replace submodules with wrap files Michal Prívozník
2023-06-07 7:47 ` Daniel P. Berrangé
2023-06-07 8:54 ` Michal Prívozník
2023-06-07 8:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jnm19v8.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.